You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/08/14 12:06:44 UTC
[kudu-CR] Improve some comments in the tablet compaction code
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3973
to review the following change.
Change subject: Improve some comments in the tablet compaction code
......................................................................
Improve some comments in the tablet compaction code
Also fix typo in hybrid clock header docs
Change-Id: I4e53635cefd9611d8dc4ae8e2ff105d04a96aa6d
---
M src/kudu/common/row_changelist.h
M src/kudu/server/hybrid_clock.h
M src/kudu/tablet/delta_compaction.cc
3 files changed, 18 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/3973/1
--
To view, visit http://gerrit.cloudera.org:8080/3973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e53635cefd9611d8dc4ae8e2ff105d04a96aa6d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Improve some comments in the tablet compaction code
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Improve some comments in the tablet compaction code
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2871/
--
To view, visit http://gerrit.cloudera.org:8080/3973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e53635cefd9611d8dc4ae8e2ff105d04a96aa6d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Improve some comments in the tablet compaction code
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change.
Change subject: Improve some comments in the tablet compaction code
......................................................................
Abandoned
Superceded by https://gerrit.cloudera.org/3977
--
To view, visit http://gerrit.cloudera.org:8080/3973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I4e53635cefd9611d8dc4ae8e2ff105d04a96aa6d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Improve some comments in the tablet compaction code
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Improve some comments in the tablet compaction code
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/2876/
--
To view, visit http://gerrit.cloudera.org:8080/3973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e53635cefd9611d8dc4ae8e2ff105d04a96aa6d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No