You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/09 20:46:33 UTC
[GitHub] lanking520 commented on a change in pull request #12110:
[MXNET-730][WIP] Scala test in nightly
lanking520 commented on a change in pull request #12110: [MXNET-730][WIP] Scala test in nightly
URL: https://github.com/apache/incubator-mxnet/pull/12110#discussion_r209073375
##########
File path: scala-package/examples/src/main/scala/org/apache/mxnetexamples/Util.scala
##########
@@ -42,4 +48,30 @@ object Util {
}
if (!success) throw new Exception(s"$url Download failed!")
}
+
+ /**
+ * This Util is designed to manage the tests in CI
+ * @param name the name of the test
+ * @return runTest and number of epoch
+ */
+ def testManager(name: String) : (Boolean, Int) = {
Review comment:
Then there will be 10+ lines maven configuration and fragments of checking in the tests to achieve the same functionalities. I believe placing them all together into one place is better to manage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services