You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by GitBox <gi...@apache.org> on 2022/02/10 04:03:17 UTC
[GitHub] [bahir-flink] 1996fanrui opened a new pull request #144: [BAHIR-299] Replace _2.11 with _${scala.binary.version}
1996fanrui opened a new pull request #144:
URL: https://github.com/apache/bahir-flink/pull/144
https://issues.apache.org/jira/browse/BAHIR-299
When use scala-2.12, maven artifactId should result in _2.12, but a lot of bahir-flink code is hardcoded to _2.11. Using _${scala.binary.version} is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] eskabetxe commented on pull request #144: [BAHIR-299] Replace _2.11 with _${scala.binary.version}
Posted by GitBox <gi...@apache.org>.
eskabetxe commented on pull request #144:
URL: https://github.com/apache/bahir-flink/pull/144#issuecomment-1039200877
Hi @1996fanrui, thanks for your contribution..
We have a script to change the scala version (https://github.com/apache/bahir-flink/blob/master/dev/change-scala-version.sh)
Meanwhile, with the changes in flink 1.15 with "scala free" and the remove of all related scala versions from dependencies, I will prefer to wait and remove all the scala.version from dependencies too
@rmetzger , @lresende
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] 1996fanrui closed pull request #144: [BAHIR-299] Replace _2.11 with _${scala.binary.version}
Posted by GitBox <gi...@apache.org>.
1996fanrui closed pull request #144:
URL: https://github.com/apache/bahir-flink/pull/144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] 1996fanrui commented on pull request #144: [BAHIR-299] Replace _2.11 with _${scala.binary.version}
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on pull request #144:
URL: https://github.com/apache/bahir-flink/pull/144#issuecomment-1038589218
Hi @eskabetxe , could you help to review this PR in your free time? Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] 1996fanrui commented on pull request #144: [BAHIR-299] Replace _2.11 with _${scala.binary.version}
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on pull request #144:
URL: https://github.com/apache/bahir-flink/pull/144#issuecomment-1041196661
Hi @eskabetxe Thanks a lot for your clarification. I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org