You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org> on 2026/07/17 17:20:42 UTC

[Impala-ASF-CR] IMPALA-14714: Fix incorrect results for anti-join with constant ON clause predicates

Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/23962 )

Change subject: IMPALA-14714: Fix incorrect results for anti-join with constant ON clause predicates
......................................................................


Patch Set 3:

While working on IMPALA-7996 and separating its outer-join optimization from the anti-join correctness changes, I found a remaining correctness case on PS3 with constant inline views. For example:

select a.*
from (select 1 as id union all select 2 as id) a
left anti join (select 1 as id union all select 2 as id) b on false;

The preserved left input is planned with cardinality 0, so the expected two rows are lost. ON NULL has the same issue. I reproduced this against exact PS3. It appears the constant predicate is still consumed while planning the inline-view input, so the current migration guard is not sufficient for this shape. I can help prepare a regression and fix if useful.


-- 
To view, visit http://gerrit.cloudera.org:8080/23962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e0f4a69263bb0ff11f421a1a340dffb904c6842
Gerrit-Change-Number: 23962
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 17 Jul 2026 17:20:42 +0000
Gerrit-HasComments: No