You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/01/27 13:07:34 UTC
[GitHub] [incubator-nuttx] taikoyaP opened a new pull request #170: arch/arm/src/stm32l4/stm32l4_flash.c: Fix flash_erase(page) when page…
taikoyaP opened a new pull request #170: arch/arm/src/stm32l4/stm32l4_flash.c: Fix flash_erase(page) when page…
URL: https://github.com/apache/incubator-nuttx/pull/170
… >= 256
All STM32L4 MPUs have FLASH_CR_PNB bits (8 bits), and some MPUs have FLASH_CR_BKER bit for change bank if page >= 256. But present code not set and clear FLASH_CR_BKER correctly.
Note: I tried to change macro FLASH_CR_PNB(n) in arch/arm/src/stm32l4/hardware/stm32l4_flash.h, but this file is not according to coding standard (long line), so I gave up to format this... I want to change to:
#define FLASH_CR_PNB(n) ((n & 0xFF) << FLASH_CR_PNB_SHIFT)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 merged pull request #170: arch/arm/src/stm32l4/stm32l4_flash.c: Fix flash_erase(page) when page…
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #170: arch/arm/src/stm32l4/stm32l4_flash.c: Fix flash_erase(page) when page…
URL: https://github.com/apache/incubator-nuttx/pull/170
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services