You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/04 05:57:19 UTC
[GitHub] [druid] clintropolis opened a new pull request #9309: remove
log.info from FixedBucketsHistogramAggregator aggregate method
clintropolis opened a new pull request #9309: remove log.info from FixedBucketsHistogramAggregator aggregate method
URL: https://github.com/apache/druid/pull/9309
Heh, my bad, missed this in #6638 when I +1'd it...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] fjy merged pull request #9309: remove log.info from
FixedBucketsHistogramAggregator aggregate method
Posted by GitBox <gi...@apache.org>.
fjy merged pull request #9309: remove log.info from FixedBucketsHistogramAggregator aggregate method
URL: https://github.com/apache/druid/pull/9309
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jnaous commented on a change in pull request #9309: remove
log.info from FixedBucketsHistogramAggregator aggregate method
Posted by GitBox <gi...@apache.org>.
jnaous commented on a change in pull request #9309: remove log.info from FixedBucketsHistogramAggregator aggregate method
URL: https://github.com/apache/druid/pull/9309#discussion_r374713622
##########
File path: extensions-core/histogram/src/main/java/org/apache/druid/query/aggregation/histogram/FixedBucketsHistogramAggregator.java
##########
@@ -77,7 +74,6 @@ public void aggregate()
histogram.incrementMissing();
}
} else if (val instanceof String) {
- LOG.info((String) val);
Review comment:
This makes for a good review tip!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org