You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/11 16:14:45 UTC

[GitHub] [maven-surefire] imonteroperez commented on a change in pull request #400: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile

imonteroperez commented on a change in pull request #400:
URL: https://github.com/apache/maven-surefire/pull/400#discussion_r782305865



##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -2292,23 +2291,52 @@ private void checkMethodFilterInIncludesExcludes( Iterable<String> patterns )
                 if ( pattern != null && pattern.contains( "#" ) )
                 {
                     throw new MojoFailureException( "Method filter prohibited in "
-                                                        + "includes|excludes|includesFile|excludesFile parameter: "
+                                                        + "includes|excludes parameter: "
                                                         + pattern );
                 }
             }
         }
     }
 
-    private TestListResolver getIncludedAndExcludedTests()
+    private TestListResolver solveIncludedAndExcludedTests()

Review comment:
       Updated in https://github.com/apache/maven-surefire/pull/400/commits/bc8768bccda866ee3edbb7c12a8f439ff351bcdd




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org