You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by jb...@apache.org on 2009/01/28 17:15:02 UTC
svn commit: r738523 - in /geronimo/server/trunk/plugins:
console/console-base-portlets/src/main/java/org/apache/geronimo/console/ca/SetupCAHandler.java
monitoring/mconsole-war/src/main/java/org/apache/geronimo/monitoring/console/MonitoringPortlet.java
Author: jbohn
Date: Wed Jan 28 16:15:02 2009
New Revision: 738523
URL: http://svn.apache.org/viewvc?rev=738523&view=rev
Log:
do not echo back passwords to user when they are not necessary
Modified:
geronimo/server/trunk/plugins/console/console-base-portlets/src/main/java/org/apache/geronimo/console/ca/SetupCAHandler.java
geronimo/server/trunk/plugins/monitoring/mconsole-war/src/main/java/org/apache/geronimo/monitoring/console/MonitoringPortlet.java
Modified: geronimo/server/trunk/plugins/console/console-base-portlets/src/main/java/org/apache/geronimo/console/ca/SetupCAHandler.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/console/console-base-portlets/src/main/java/org/apache/geronimo/console/ca/SetupCAHandler.java?rev=738523&r1=738522&r2=738523&view=diff
==============================================================================
--- geronimo/server/trunk/plugins/console/console-base-portlets/src/main/java/org/apache/geronimo/console/ca/SetupCAHandler.java (original)
+++ geronimo/server/trunk/plugins/console/console-base-portlets/src/main/java/org/apache/geronimo/console/ca/SetupCAHandler.java Wed Jan 28 16:15:02 2009
@@ -49,7 +49,7 @@
}
public String actionBeforeView(ActionRequest request, ActionResponse response, MultiPageModel model) throws PortletException, IOException {
- String[] params = {"caCN", "caOU", "caO", "caL", "caST", "caC", "alias", "keyAlgorithm", "keySize", "algorithm", "validFrom", "validTo", "sNo", "password"};
+ String[] params = {"caCN", "caOU", "caO", "caL", "caST", "caC", "alias", "keyAlgorithm", "keySize", "algorithm", "validFrom", "validTo", "sNo"};
for(int i = 0; i < params.length; ++i) {
String value = request.getParameter(params[i]);
if(value != null) response.setRenderParameter(params[i], value);
@@ -58,7 +58,7 @@
}
public void renderView(RenderRequest request, RenderResponse response, MultiPageModel model) throws PortletException, IOException {
- String[] params = {"caCN", "caOU", "caO", "caL", "caST", "caC", "alias", "keyAlgorithm", "keySize", "algorithm", "validFrom", "validTo", "sNo", "password"};
+ String[] params = {"caCN", "caOU", "caO", "caL", "caST", "caC", "alias", "keyAlgorithm", "keySize", "algorithm", "validFrom", "validTo", "sNo"};
for(int i = 0; i < params.length; ++i) {
Object value = request.getParameter(params[i]);
if(value != null) request.setAttribute(params[i], value);
Modified: geronimo/server/trunk/plugins/monitoring/mconsole-war/src/main/java/org/apache/geronimo/monitoring/console/MonitoringPortlet.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/monitoring/mconsole-war/src/main/java/org/apache/geronimo/monitoring/console/MonitoringPortlet.java?rev=738523&r1=738522&r2=738523&view=diff
==============================================================================
--- geronimo/server/trunk/plugins/monitoring/mconsole-war/src/main/java/org/apache/geronimo/monitoring/console/MonitoringPortlet.java (original)
+++ geronimo/server/trunk/plugins/monitoring/mconsole-war/src/main/java/org/apache/geronimo/monitoring/console/MonitoringPortlet.java Wed Jan 28 16:15:02 2009
@@ -217,8 +217,9 @@
actionResponse.setRenderParameter("name", name);
actionResponse.setRenderParameter("username", username);
actionResponse.setRenderParameter("ip", ip);
- actionResponse.setRenderParameter("password", password);
- actionResponse.setRenderParameter("password2", password2);
+ // Don't return the password in the output
+// actionResponse.setRenderParameter("password", password);
+// actionResponse.setRenderParameter("password2", password2);
actionResponse.setRenderParameter("port", "" + port);
actionResponse.setRenderParameter("protocol", protocol);
} else if (action.equals("testEditServerConnection")) {
@@ -242,8 +243,9 @@
actionResponse.setRenderParameter("name", name);
actionResponse.setRenderParameter("username", username);
actionResponse.setRenderParameter("ip", ip);
- actionResponse.setRenderParameter("password", password);
- actionResponse.setRenderParameter("password2", password2);
+ // Don't return the password in the output
+// actionResponse.setRenderParameter("password", password);
+// actionResponse.setRenderParameter("password2", password2);
actionResponse.setRenderParameter("snapshot", snapshot);
actionResponse.setRenderParameter("server_id", server_id);
actionResponse.setRenderParameter("retention", retention);