You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/21 06:42:25 UTC

[GitHub] [apisix] spacewander commented on a change in pull request #3088: feat: add control api for plugin server-info

spacewander commented on a change in pull request #3088:
URL: https://github.com/apache/apisix/pull/3088#discussion_r546534487



##########
File path: apisix/plugins/server-info.lua
##########
@@ -99,6 +99,17 @@ local function get()
 end
 
 
+local function get_server_info()
+    local info, err = get()

Review comment:
       Look like we need to way to store the `boot_time` in shdict when `etcd` is not used. Otherwise the `boot_time` will change when plugin reloads.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org