[shardingsphere] branch master updated: Code little optimized. (#22584)

[zh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new bec6b2d25a9 Code little optimized. (#22584)
bec6b2d25a9 is described below

commit bec6b2d25a90b16b8d41f93fe08a64e4c2c04dbe
Author: Chuxin Chen <ch...@qq.com>
AuthorDate: Fri Dec 2 15:08:50 2022 +0800

    Code little optimized. (#22584)
---
 .../engine/type/standard/ShardingStandardRoutingEngine.java    |  2 +-
 .../org/apache/shardingsphere/infra/hint/SQLHintUtils.java     | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/engine/type/standard/ShardingStandardRoutingEngine.java b/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/engine/type/standard/ShardingStandardRoutingEngine.java
index 678d0750151..1a935330f5c 100644
--- a/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/engine/type/standard/ShardingStandardRoutingEngine.java
+++ b/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/engine/type/standard/ShardingStandardRoutingEngine.java
@@ -66,7 +66,7 @@ public final class ShardingStandardRoutingEngine implements ShardingRouteEngine
     
     private final Collection<Collection<DataNode>> originalDataNodes = new LinkedList<>();
     
-    private SQLHintExtractor sqlHintExtractor;
+    private final SQLHintExtractor sqlHintExtractor;
     
     public ShardingStandardRoutingEngine(final String logicTableName, final ShardingConditions shardingConditions, final SQLStatementContext<?> sqlStatementContext,
                                          final HintValueContext hintValueContext, final ConfigurationProperties props) {
diff --git a/infra/common/src/main/java/org/apache/shardingsphere/infra/hint/SQLHintUtils.java b/infra/common/src/main/java/org/apache/shardingsphere/infra/hint/SQLHintUtils.java
index eab622366c2..a504a3a5bb1 100644
--- a/infra/common/src/main/java/org/apache/shardingsphere/infra/hint/SQLHintUtils.java
+++ b/infra/common/src/main/java/org/apache/shardingsphere/infra/hint/SQLHintUtils.java
@@ -106,22 +106,22 @@ public final class SQLHintUtils {
         String hintText = sql.substring(0, sql.indexOf(SQL_COMMENT_SUFFIX) + 2);
         Properties hintProperties = SQLHintUtils.getSQLHintProps(hintText);
         if (hintProperties.containsKey(SQLHintPropertiesKey.WRITE_ROUTE_ONLY_KEY.getKey())) {
-            result.setWriteRouteOnly(Boolean.valueOf(hintProperties.getProperty(SQLHintPropertiesKey.WRITE_ROUTE_ONLY_KEY.getKey())));
+            result.setWriteRouteOnly(Boolean.parseBoolean(hintProperties.getProperty(SQLHintPropertiesKey.WRITE_ROUTE_ONLY_KEY.getKey())));
         }
         if (hintProperties.containsKey(SQLHintPropertiesKey.USE_TRAFFIC_KEY.getKey())) {
-            result.setUseTraffic(Boolean.valueOf(hintProperties.getProperty(SQLHintPropertiesKey.USE_TRAFFIC_KEY.getKey())));
+            result.setUseTraffic(Boolean.parseBoolean(hintProperties.getProperty(SQLHintPropertiesKey.USE_TRAFFIC_KEY.getKey())));
         }
         if (hintProperties.containsKey(SQLHintPropertiesKey.SKIP_ENCRYPT_REWRITE_KEY.getKey())) {
-            result.setSkipEncryptRewrite(Boolean.valueOf(hintProperties.getProperty(SQLHintPropertiesKey.SKIP_ENCRYPT_REWRITE_KEY.getKey())));
+            result.setSkipEncryptRewrite(Boolean.parseBoolean(hintProperties.getProperty(SQLHintPropertiesKey.SKIP_ENCRYPT_REWRITE_KEY.getKey())));
         }
         if (hintProperties.containsKey(SQLHintPropertiesKey.DISABLE_AUDIT_NAMES_KEY.getKey())) {
             result.setDisableAuditNames(hintProperties.getProperty(SQLHintPropertiesKey.DISABLE_AUDIT_NAMES_KEY.getKey()));
         }
         if (hintProperties.containsKey(SQLHintPropertiesKey.SHADOW_KEY.getKey())) {
-            result.setShadow(Boolean.valueOf(hintProperties.getProperty(SQLHintPropertiesKey.SHADOW_KEY.getKey())));
+            result.setShadow(Boolean.parseBoolean(hintProperties.getProperty(SQLHintPropertiesKey.SHADOW_KEY.getKey())));
         }
         for (Entry<Object, Object> entry : hintProperties.entrySet()) {
-            Comparable value = entry.getValue() instanceof Comparable ? (Comparable<?>) entry.getValue() : Objects.toString(entry.getValue());
+            Comparable<?> value = entry.getValue() instanceof Comparable ? (Comparable<?>) entry.getValue() : Objects.toString(entry.getValue());
             if (Objects.toString(entry.getKey()).contains(SQLHintPropertiesKey.SHARDING_DATABASE_VALUE_KEY.getKey())) {
                 result.getShardingDatabaseValues().put(Objects.toString(entry.getKey()), value);
             }