You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/04/03 21:10:05 UTC
[PR] Fix #11796: Preserve cross-lifecycle default phase bindings from components.xml [maven]
gnodet opened a new pull request, #11890:
URL: https://github.com/apache/maven/pull/11890
## Summary
- Fixes Maven 4 ignoring `<default-phases>` from `components.xml` when they bind goals to standard lifecycle phases (e.g. `process-sources`) rather than to the custom lifecycle's own phases
- The `LifecycleWrapperProvider.wrap()` method now separates `v3phases()` (for phase ordering) from `phases()` (for plugin binding extraction), preserving cross-lifecycle bindings during the round-trip conversion
- Adds test verifying that cross-lifecycle default phase bindings survive the legacy-to-API-to-legacy Lifecycle conversion
Closes #11796
## Test plan
- [x] New unit test `testCustomLifecycleWithCrossLifecycleDefaultPhases` verifies cross-lifecycle bindings are preserved
- [x] All 544 existing maven-core tests pass with no regressions
- [ ] Manual test with reproducer from https://github.com/mariuszs/extension-maven-plugin
🤖 Generated with [Claude Code](https://claude.com/claude-code)
_Claude Code on behalf of Guillaume Nodet_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #11796: Preserve cross-lifecycle default phase bindings from components.xml [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #11890:
URL: https://github.com/apache/maven/pull/11890#issuecomment-4505542058
Closing as duplicate of #11889, which takes the same approach and additionally includes an integration test.
_Claude Code on behalf of Guillaume Nodet_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #11796: Preserve cross-lifecycle default phase bindings from components.xml [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet closed pull request #11890: Fix #11796: Preserve cross-lifecycle default phase bindings from components.xml
URL: https://github.com/apache/maven/pull/11890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org