You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/07 13:20:00 UTC

[jira] [Commented] (FLINK-9733) Make location for job graph files configurable

    [ https://issues.apache.org/jira/browse/FLINK-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535755#comment-16535755 ] 

ASF GitHub Bot commented on FLINK-9733:
---------------------------------------

GitHub user yanghua opened a pull request:

    https://github.com/apache/flink/pull/6280

    [FLINK-9733] Make location for job graph files configurable

    ## What is the purpose of the change
    
    *This pull request make location for job graph files configurable*
    
    
    ## Brief change log
    
      - *Add a config item 'rest.jobgraph-store-path' to `RestOptions`*
      - *make the config item can be accessed in `RestClusterClientConfiguration`*
      - *Use the config item when submit job in `RestClusterClient`*
    
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
    TBD
    
    *(example:)*
      - *Added integration tests for end-to-end deployment with large payloads (100MB)*
      - *Extended integration test for recovery after master (JobManager) failure*
      - *Added test that validates that TaskInfo is transferred only once across recoveries*
      - *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanghua/flink FLINK-9733

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6280
    
----
commit d20c3643519156df0d2d2c4d3648b9c7496778cc
Author: yanghua <ya...@...>
Date:   2018-07-07T13:15:36Z

    [FLINK-9733] Make location for job graph files configurable

----


> Make location for job graph files configurable
> ----------------------------------------------
>
>                 Key: FLINK-9733
>                 URL: https://issues.apache.org/jira/browse/FLINK-9733
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client, Job-Submission
>    Affects Versions: 1.5.1, 1.6.0
>            Reporter: Chesnay Schepler
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>
> During the job-submission by the {{RestClusterClient}} the {{JobGraph}} is serialized and written to a file.
> Currently we just use {{Files.createTempFile}} for this purposes.
> This location should be made configurable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)