[jira] [Commented] (YARN-3463) Integrate OrderingPolicy Framework with CapacityScheduler

["Wangda Tan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494858#comment-14494858 ] 

Wangda Tan commented on YARN-3463:
----------------------------------

[~cwelch], did a quick look at this, some quick comments about patch scope:
1) Preemption policy changes seems not correct to me, for example, 4 apps in a queue, usages for app1-app4 are: 4/6/3/7, and need claim 8 resources back. With this change, it will get 6 from app4, 2 from app2. After preemption is: 4/4/3/1. And actually it should get 1 from app1, 3 from app2, 4 from app 4, after preemption is: 3/3/3/3.

Since the preemption policy changes potentially big, let's move it to a separated patch.

2) WebUI, REST API and CLI changes are public APIs and related to core changes in CS. I suggest to move it to a separated patch.

So I suggest only leave core changes for CS including configuration and scheduler in the patch for easier review as well as less reworks needed.

Agree?

> Integrate OrderingPolicy Framework with CapacityScheduler
> ---------------------------------------------------------
>
>                 Key: YARN-3463
>                 URL: https://issues.apache.org/jira/browse/YARN-3463
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Craig Welch
>            Assignee: Craig Welch
>         Attachments: YARN-3463.50.patch, YARN-3643.58.patch
>
>
> Integrate the OrderingPolicy Framework with the CapacityScheduler



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)