You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/06/03 16:02:07 UTC

[GitHub] [logging-log4j2] arturobernalg commented on a change in pull request #502: Improvements:

arturobernalg commented on a change in pull request #502:
URL: https://github.com/apache/logging-log4j2/pull/502#discussion_r644923664



##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/FileExtension.java
##########
@@ -95,7 +95,7 @@ public static FileExtension lookupForFile(final String fileName) {
 
     private final String extension;
 
-    private FileExtension(final String extension) {
+    FileExtension(final String extension) {

Review comment:
       IMO it's redundant. according with java doc 'The constructor for an enum type must be package-private or private access'.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org