You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "karan singh malhi (JIRA)" <ji...@apache.org> on 2007/08/20 20:51:30 UTC

[jira] Created: (OPENEJB-667) OpenEJB server prints logging messages to console.

OpenEJB server prints logging messages to console.
--------------------------------------------------

                 Key: OPENEJB-667
                 URL: https://issues.apache.org/jira/browse/OPENEJB-667
             Project: OpenEJB
          Issue Type: Bug
          Components: general
            Reporter: karan singh malhi


Standalone server prints logging messages to the console. Need to append messages to logs/openejb.log and logs/transaction.log

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OPENEJB-667) OpenEJB server prints logging messages to console.

Posted by "Manu T George (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manu T George reassigned OPENEJB-667:
-------------------------------------

    Assignee: Manu T George

> OpenEJB server prints logging messages to console.
> --------------------------------------------------
>
>                 Key: OPENEJB-667
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-667
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: general
>            Reporter: karan singh malhi
>            Assignee: Manu T George
>         Attachments: openejb-667.patch
>
>
> Standalone server prints logging messages to the console. Need to append messages to logs/openejb.log and logs/transaction.log

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENEJB-667) OpenEJB server prints logging messages to console.

Posted by "karan singh malhi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

karan singh malhi updated OPENEJB-667:
--------------------------------------

    Attachment: openejb-667.patch

Here is the algorithm for logging:
It is assumed that openejb-core-XXX.jar  has a logging.properties and a embedded.logging.properties.
Then we would follow the proposed algorithm:

   - if conf/logging.properties exists, use it
   - if conf/ directory exists, install openejb-core.jar!/logging.properties to conf/logging.properties and use it. If logging.properties not found in the jar file (not possible ) then use log4.configuration system property and also display an error in the console that logging.properties file is missing
        
   - else assume embedded and use openejb-core.jar!/
embedded.logging.properties.If embedded.logging.properties not found in the jar file (not possible ) then use log4.configuration system property and also display an error in the console that embedded.logging.properties file is missing. This has an advantage in tests in that one could simply create their own my.embedded.logging.properties file with their own custom logging configuration and update the log4.configuration system property to point to my.embedded.logging.properties file. This way you can really do custom logging without changing anything in embedded.logging.properties (and then reverting it back before submitting a patch). 

The logging.properties would be setup with file appenders similar to the way the default.logging.conf was earlier.

> OpenEJB server prints logging messages to console.
> --------------------------------------------------
>
>                 Key: OPENEJB-667
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-667
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: general
>            Reporter: karan singh malhi
>         Attachments: openejb-667.patch
>
>
> Standalone server prints logging messages to the console. Need to append messages to logs/openejb.log and logs/transaction.log

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OPENEJB-667) OpenEJB server prints logging messages to console.

Posted by "Manu T George (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manu T George reassigned OPENEJB-667:
-------------------------------------

    Assignee: karan singh malhi  (was: Manu T George)

Pls test and close

> OpenEJB server prints logging messages to console.
> --------------------------------------------------
>
>                 Key: OPENEJB-667
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-667
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: general
>            Reporter: karan singh malhi
>            Assignee: karan singh malhi
>         Attachments: openejb-667.patch
>
>
> Standalone server prints logging messages to the console. Need to append messages to logs/openejb.log and logs/transaction.log

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OPENEJB-667) OpenEJB server prints logging messages to console.

Posted by "David Blevins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Blevins closed OPENEJB-667.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0

> OpenEJB server prints logging messages to console.
> --------------------------------------------------
>
>                 Key: OPENEJB-667
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-667
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: general
>            Reporter: karan singh malhi
>            Assignee: karan singh malhi
>             Fix For: 3.0
>
>         Attachments: openejb-667.patch
>
>
> Standalone server prints logging messages to the console. Need to append messages to logs/openejb.log and logs/transaction.log

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENEJB-667) OpenEJB server prints logging messages to console.

Posted by "karan singh malhi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

karan singh malhi updated OPENEJB-667:
--------------------------------------

    Attachment: openejb-667.patch

Made the following changes:

1. Got rid of the init(), initialize() methods and the Log4jConfigUtils inner class
2. On class load, it will configure logging. The logic is as follows (taken from David Blevins' email)

  - if conf/logging.properties exists, use it
  - if conf/ directory exists, install logging.properties and use it
  - else assume embedded and use embedded.logging.properties 

(I did not explicitly look for the third step (embedded.logging.properties) file, because this can be set through the log4j.configuration property when we run tests. This way we still keep the flexibility on the filename during tests , but we are a little more rigid with the user in that the user will have to specify the logging config in the conf/logging.properties file.

> OpenEJB server prints logging messages to console.
> --------------------------------------------------
>
>                 Key: OPENEJB-667
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-667
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: general
>            Reporter: karan singh malhi
>         Attachments: openejb-667.patch
>
>
> Standalone server prints logging messages to the console. Need to append messages to logs/openejb.log and logs/transaction.log

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENEJB-667) OpenEJB server prints logging messages to console.

Posted by "Jacek Laskowski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacek Laskowski updated OPENEJB-667:
------------------------------------

    Attachment:     (was: openejb-667.patch)

> OpenEJB server prints logging messages to console.
> --------------------------------------------------
>
>                 Key: OPENEJB-667
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-667
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: general
>            Reporter: karan singh malhi
>
> Standalone server prints logging messages to the console. Need to append messages to logs/openejb.log and logs/transaction.log

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENEJB-667) OpenEJB server prints logging messages to console.

Posted by "Manu T George (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENEJB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521732 ] 

Manu T George commented on OPENEJB-667:
---------------------------------------

commited at 568493 in trunk

> OpenEJB server prints logging messages to console.
> --------------------------------------------------
>
>                 Key: OPENEJB-667
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-667
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: general
>            Reporter: karan singh malhi
>            Assignee: Manu T George
>         Attachments: openejb-667.patch
>
>
> Standalone server prints logging messages to the console. Need to append messages to logs/openejb.log and logs/transaction.log

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.