You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/08/26 09:14:51 UTC

[GitHub] [zookeeper] yuMoyu commented on pull request #1738: Update zookeeperTutorial.md

yuMoyu commented on pull request #1738:
URL: https://github.com/apache/zookeeper/pull/1738#issuecomment-906235870


   > * Good catch. @yuMoyu Thanks for this contribution. It's better to create a [JIRA](https://issues.apache.org/jira/projects/ZOOKEEPER/) issue (sign up JIRA if you don't have an account) to bind this PR to a JIRA-ID. ZooKeeper uses the GitHub workflow. The contributor guideline is [here](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute)
   > * please write the GitHub description with English, other than Chinese
   > * I believe that the implementation of barrier must have other places to improve. Could you please try to improve it?
   >   the following is a good references:
   >   
   >   * https://curator.apache.org/curator-recipes/barrier.html
   >   * https://github.com/apache/curator/blob/master/curator-recipes/src/main/java/org/apache/curator/framework/recipes/barriers/DistributedBarrier.java#L70
   
   Sorry, I don't quite understand which of the following you mean. 1、 The improvements I mentioned can be optimized. 2、 There are other aspects that can be improved in this document. 3、 the classes in the link can be improved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org