You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/26 08:39:22 UTC

[GitHub] [iotdb] neuyilan commented on a change in pull request #4034: [IOTDB-1738] Cache paths list in batched insert plan

neuyilan commented on a change in pull request #4034:
URL: https://github.com/apache/iotdb/pull/4034#discussion_r716167176



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/metadata/CMManager.java
##########
@@ -563,10 +569,11 @@ public void createSchema(PhysicalPlan plan) throws MetadataException, CheckConsi
 
   private List<PartialPath> getValidStorageGroups(PhysicalPlan plan) {
     List<PartialPath> paths = new ArrayList<>();
-    for (int i = 0; i < plan.getPaths().size(); i++) {
+    List<PartialPath> originalPaths = plan.getPaths();
+    for (int i = 0; i < originalPaths.size(); i++) {

Review comment:
       The `(BatchPlan) plan).getResults().containsKey(i)` here are those plans that do not have authority to operate, so here we do not process those plans. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org