[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #150: Introduce more grpc server metrics

[GitBox <gi...@apache.org>]

zuston commented on code in PR #150:
URL: https://github.com/apache/incubator-uniffle/pull/150#discussion_r946372521


##########
common/src/main/java/org/apache/uniffle/common/metrics/GRPCMetrics.java:
##########
@@ -25,6 +25,13 @@
 import io.prometheus.client.Gauge;
 
 public abstract class GRPCMetrics {
+  // Grpc server internal executor metrics
+  public static final String GRPC_SERVER_EXECUTOR_ACTIVE_THREADS_TAG = "grpcServerExecutorActiveThreads";
+  public static final String GRPC_SERVER_EXECUTOR_BLOCKING_QUEUE_SIZE_TAG = "grpcServerExecutorBlockingQueueSize";
+  private static final String GRPC_SERVER_EXECUTOR_ACTIVE_THREADS = "grpc_server_executor_active_threads";
+  private static final String GRPC_SERVER_EXECUTOR_BLOCKING_QUEUE_SIZE = "grpc_server_executor_blocking_queue_size";
+  public static final String GRCP_SERVER_CONNECTION_SIZE_TAG = "grpc_server_connection_size";
+  private static final String GRCP_SERVER_CONNECTION_SOCKETS_SIZE = "grpc_server_connection_size";

Review Comment:
   My mistake. It should be like `public static final String GRCP_SERVER_CONNECTION_SIZE_TAG = "grpcServerConnectionSize"`.
   
   And `GRCP_SERVER_CONNECTION_SOCKETS_SIZE` rename to `GRCP_SERVER_CONNECTION_SIZE` to keep consistent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org