You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/25 16:52:15 UTC

[GitHub] [beam] jkff commented on a change in pull request #14338: [BEAM-12044] JdbcIO read: always force autocommit to false

jkff commented on a change in pull request #14338:
URL: https://github.com/apache/beam/pull/14338#discussion_r601669177



##########
File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -903,6 +903,8 @@ public void processElement(ProcessContext context) throws Exception {
       if (connection == null) {
         connection = dataSource.getConnection();
       }
+      // PostgreSQL requires autocommit to be disabled to enable cursor streaming

Review comment:
       drive-by: could you include the Postgres documentation link in this comment?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org