You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/11/18 16:31:01 UTC
[GitHub] [activemq-artemis] hawkdshrh opened a new pull request, #4292: ARTEMIS-4093: Expose properties and support resource adapter in J2EE environments
hawkdshrh opened a new pull request, #4292:
URL: https://github.com/apache/activemq-artemis/pull/4292
Fixes to expose properties in environments not recognizing is* accessors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] hawkdshrh commented on a diff in pull request #4292: ARTEMIS-4093: Expose properties and support resource adapter in J2EE environments
Posted by GitBox <gi...@apache.org>.
hawkdshrh commented on code in PR #4292:
URL: https://github.com/apache/activemq-artemis/pull/4292#discussion_r1029344555
##########
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQResourceAdapter.java:
##########
@@ -821,6 +821,10 @@ public void setUseTopologyForLoadBalancing(Boolean useTopologyForLoadBalancing)
raProperties.setUseTopologyForLoadBalancing(useTopologyForLoadBalancing);
}
+ public Boolean getUseTopologyForLoadBalancing() {
+ return raProperties.isUseTopologyForLoadBalancing();
Review Comment:
Unfortunately, this is not recognized in some environments. Websphere Application Server 8.x is one of these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a diff in pull request #4292: ARTEMIS-4093: Expose properties and support resource adapter in J2EE environments
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on code in PR #4292:
URL: https://github.com/apache/activemq-artemis/pull/4292#discussion_r1027304656
##########
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java:
##########
@@ -619,6 +649,10 @@ public void setUseLocalTx(final Boolean localTx) {
this.localTx = localTx;
}
+ public Boolean getRebalanceConnections() {
Review Comment:
why? same question as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4292: ARTEMIS-4093: Expose properties and support resource adapter in J2EE environments
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on PR #4292:
URL: https://github.com/apache/activemq-artemis/pull/4292#issuecomment-1320925894
you should rebase this, and fix the title of your commit. you amend the wrong commit..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4292: ARTEMIS-4093: Expose properties and support resource adapter in J2EE environments
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on PR #4292:
URL: https://github.com/apache/activemq-artemis/pull/4292#issuecomment-1320926338
I converted your commit to draft until you fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] hawkdshrh commented on a diff in pull request #4292: ARTEMIS-4093: Expose properties and support resource adapter in J2EE environments
Posted by GitBox <gi...@apache.org>.
hawkdshrh commented on code in PR #4292:
URL: https://github.com/apache/activemq-artemis/pull/4292#discussion_r1029345839
##########
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java:
##########
@@ -619,6 +649,10 @@ public void setUseLocalTx(final Boolean localTx) {
this.localTx = localTx;
}
+ public Boolean getRebalanceConnections() {
Review Comment:
Unfortunately, these methods are not recognized in some environments, causing failure to expose the properties (Websphere Application Server is one such).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev merged pull request #4292: ARTEMIS-4093: Expose properties and support resource adapter in J2EE environments
Posted by GitBox <gi...@apache.org>.
brusdev merged PR #4292:
URL: https://github.com/apache/activemq-artemis/pull/4292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a diff in pull request #4292: ARTEMIS-4093: Expose properties and support resource adapter in J2EE environments
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on code in PR #4292:
URL: https://github.com/apache/activemq-artemis/pull/4292#discussion_r1027304601
##########
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQResourceAdapter.java:
##########
@@ -821,6 +821,10 @@ public void setUseTopologyForLoadBalancing(Boolean useTopologyForLoadBalancing)
raProperties.setUseTopologyForLoadBalancing(useTopologyForLoadBalancing);
}
+ public Boolean getUseTopologyForLoadBalancing() {
+ return raProperties.isUseTopologyForLoadBalancing();
Review Comment:
why?
isUseTopology is the standard for Java Beans.
Why do you need the get method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org