You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by audreyso <gi...@git.apache.org> on 2017/04/05 21:07:08 UTC
[GitHub] cordova-android pull request #372: CB-12617 : removed node0.x support for an...
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-android/pull/372
CB-12617 : removed node0.x support for android and added engineStrict
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
Removed node0.x support for cordova-android and added engineStrict
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-android CB-12617
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/372.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #372
----
commit 5284e7f1d678ad5624721b15f5621823f8e2621c
Author: Audrey So <au...@apache.org>
Date: 2017-04-05T20:59:27Z
CB-12617 : removed node0.x support for platforms and added engineStrict
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #372: CB-12617 : removed node0.x support for an...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/372
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #372: CB-12617 : removed node0.x support for android a...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/372
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/372?src=pr&el=h1) Report
> Merging [#372](https://codecov.io/gh/apache/cordova-android/pull/372?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/8e0f021cade1367fc2ffb5d02653f511115198da?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/372?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #372 +/- ##
=======================================
Coverage 42.95% 42.95%
=======================================
Files 14 14
Lines 1362 1362
Branches 252 252
=======================================
Hits 585 585
Misses 777 777
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/372?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/372?src=pr&el=footer). Last update [8e0f021...5284e7f](https://codecov.io/gh/apache/cordova-android/pull/372?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org