Re: [PR] fix: Ensure nanoarrow-testing can be linked to in a shared Windows build [arrow-nanoarrow]

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #770:
URL: https://github.com/apache/arrow-nanoarrow/pull/770#discussion_r2135009941


##########
src/nanoarrow/testing/testing.cc:
##########
@@ -611,7 +611,7 @@ TestingJSONWriter::TestingJSONWriter()
       include_metadata_(true),
       dictionaries_(new internal::DictionaryContext()) {}
 
-TestingJSONWriter::~TestingJSONWriter() = default;
+TestingJSONWriter::~TestingJSONWriter() { delete dictionaries_; };

Review Comment:
   It might be worth adding a quick note about why we have to use new/delete here instead of unique_ptr as I think this will look odd to people who don't develop on Windows often



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org