You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ha...@apache.org on 2026/04/20 15:01:30 UTC
(superset) branch master updated: fix(sqllab): remove duplicate tooltip on share query link icon (#39289)
This is an automated email from the ASF dual-hosted git repository.
hainenber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 16387b08153 fix(sqllab): remove duplicate tooltip on share query link icon (#39289)
16387b08153 is described below
commit 16387b08153e2b0f35742c830519b66ae1322fb4
Author: Arunkumar S <32...@users.noreply.github.com>
AuthorDate: Mon Apr 20 20:31:21 2026 +0530
fix(sqllab): remove duplicate tooltip on share query link icon (#39289)
---
.../ShareSqlLabQuery/ShareSqlLabQuery.test.tsx | 19 +++++++++++++++++++
.../src/SqlLab/components/ShareSqlLabQuery/index.tsx | 1 +
2 files changed, 20 insertions(+)
diff --git a/superset-frontend/src/SqlLab/components/ShareSqlLabQuery/ShareSqlLabQuery.test.tsx b/superset-frontend/src/SqlLab/components/ShareSqlLabQuery/ShareSqlLabQuery.test.tsx
index 33b408eeedd..5d9f41da115 100644
--- a/superset-frontend/src/SqlLab/components/ShareSqlLabQuery/ShareSqlLabQuery.test.tsx
+++ b/superset-frontend/src/SqlLab/components/ShareSqlLabQuery/ShareSqlLabQuery.test.tsx
@@ -124,6 +124,25 @@ describe('ShareSqlLabQuery', () => {
).toEqual(expected);
});
+ test('does not show duplicate "Copy to clipboard" tooltip on hover', async () => {
+ await act(async () => {
+ render(<ShareSqlLabQuery {...defaultProps} />, {
+ useRedux: true,
+ store,
+ });
+ });
+ const button = screen.getByRole('button');
+ userEvent.hover(button);
+ expect(
+ await screen.findByText('Copy query link to your clipboard'),
+ ).toBeInTheDocument();
+ await waitFor(() => {
+ // CopyToClipboard default tooltip must NOT appear —
+ // only the Button-level "Copy query link to your clipboard" should show.
+ expect(screen.queryByText('Copy to clipboard')).not.toBeInTheDocument();
+ });
+ });
+
test('calls storeQuery() with unsaved changes', async () => {
await act(async () => {
render(<ShareSqlLabQuery {...defaultProps} />, {
diff --git a/superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx b/superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx
index 956ab6fc2b8..f3ce5b80ce2 100644
--- a/superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx
+++ b/superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx
@@ -89,6 +89,7 @@ const ShareSqlLabQuery = ({
getText={getCopyUrl}
wrapped={false}
copyNode={buildButton()}
+ hideTooltip
/>
);
};