[jira] [Closed] (HTTPCLIENT-1883) Add https.proxy* documentation to HttpClientBuilder

["Marcel Stör (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcel Stör closed HTTPCLIENT-1883.
-----------------------------------

Thanks [~olegk], I somehow suspected that a proper fix included more than just amending the Javadoc.

> Add https.proxy* documentation to HttpClientBuilder
> ---------------------------------------------------
>
>                 Key: HTTPCLIENT-1883
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1883
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>    Affects Versions: 4.5.3
>            Reporter: Marcel Stör
>              Labels: documentation
>             Fix For: 4.5.4, 4.6 Alpha1, 5.0 Beta1
>
>
> To amend HTTPCLIENT-1128 I guess...
> I find the list of [{{http.proxy*}} system properties in the type Javadoc for {{HttpClientBuilder}}|https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L140] a bit misleading.
> The JVM distinguishes between HTTP and HTTPS proxy settings (decide for yourself how much sense that makes) but the Javadoc comment only talks about {{http.proxy*}} system properties and not {{https.proxy*}} system properties. One might come to the conclusion that by using {{#useSystemProperties()}} on the builder you'd only get proxy support for HTTP connections but not for HTTPS. 
> Adding a short note about that would be appropriate IMO.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org