[GitHub] [kafka] C0urante commented on pull request #11894: KAFKA-13613: Remove hard dependency on HmacSHA256 algorithm for Connect

[GitBox <gi...@apache.org>]

C0urante commented on PR #11894:
URL: https://github.com/apache/kafka/pull/11894#issuecomment-1170557691

   I didn't really consider a KIP, no. This is a rare enough case that it doesn't seem worth the effort or potential API pollution to try to address with the out-of-the-box `ConfigDef` API. I'll also admit to a certain bias against expanding the config-related APIs as it's difficult to leverage those in connectors without breaking compatibility with older versions of Connect.
   
   One potential workaround that doesn't involve modifying the `ConfigDef` API is to detect the case when the worker is being run on a JVM that doesn't have the default key/signature algorithm and decline to provide a default value with the corresponding invocation of `ConfigDef::define`. This comes with a minor risk that auto-generated docs from the `DistributedConfig` class would start varying depending on the JVM they were built on, but if that's acceptable, it'd probably be a cleaner alternative to the approach in this PR.
   
   Thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org