You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@giraph.apache.org by GitBox <gi...@apache.org> on 2022/03/05 19:11:31 UTC

[GitHub] [giraph] siddhantbenadikar commented on a change in pull request #152: GIRAPH-1253: Fix vertex value reinitialized to initialValue

siddhantbenadikar commented on a change in pull request #152:
URL: https://github.com/apache/giraph/pull/152#discussion_r820138395



##########
File path: giraph-block-app-8/src/main/java/org/apache/giraph/block_app/library/pagerank/PageRankInitializeAndNormalizeEdgesPiece.java
##########
@@ -58,8 +54,6 @@
   public PageRankInitializeAndNormalizeEdgesPiece(
       ConsumerWithVertex<I, V, DoubleWritable, DoubleWritable> valueSetter,

Review comment:
       yes, only reason I didn't remove this is cause it would require constructor level changes and more changes in other files in general. But I can make them and test again




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@giraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org