You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/01/20 16:29:39 UTC
[jira] [Commented] (FLINK-3267) Disable reference tracking in Kryo fallback serializer

    [ https://issues.apache.org/jira/browse/FLINK-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108717#comment-15108717 ] 

ASF GitHub Bot commented on FLINK-3267:
---------------------------------------

GitHub user StephanEwen opened a pull request:

    https://github.com/apache/flink/pull/1528

    [FLINK-3267] Disable reference tracking in Kryo fallback serializer

    Before this commit, Kryo runs extra logic to track and resolve repeated references to
    the same object (similar as JavaSerialization)
    
    This disables reference tracking because
      - reference tracking is costly
      - it is virtually always unnecessary in the datatypes used in Flink
      - it is inconsistent with Flink's own serialization (which does not do reference tracking)
      - it may have problems if elements are read in a different order than they are written.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink kryo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1528
    
----
commit cb94002f4b38090d21e0baadbd5964ebb9c4de9d
Author: Stephan Ewen <se...@apache.org>
Date:   2016-01-20T15:26:58Z

    [FLINK-3267] Disable reference tracking in Kryo fallback serializer
    
    Before this commit, Kryo runs extra logic to track and resolve repeated references to
    the same object (similar as JavaSerialization)
    
    This disables reference tracking because
      - reference tracking is costly
      - it is virtually always unnecessary in the datatypes used in Flink
      - it is inconsistent with Flink's own serialization (which does not do reference tracking)
      - it may have problems if elements are read in a different order than they are written.

----


> Disable reference tracking in Kryo fallback serializer
> ------------------------------------------------------
>
>                 Key: FLINK-3267
>                 URL: https://issues.apache.org/jira/browse/FLINK-3267
>             Project: Flink
>          Issue Type: Bug
>          Components: Local Runtime
>    Affects Versions: 0.10.1
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Blocker
>             Fix For: 1.0.0
>
>
> Kryo runs extra logic to track and resolve repeated references to the same object (similar as JavaSerialization)
> We should disable reference tracking
>   - reference tracking is costly
>   - it is virtually always unnecessary in the datatypes used in Flink
>   - most importantly, it is inconsistent with Flink's own serialization (which does not do reference tracking)
>   - It may have problems if elements are read in a different order than they are written.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)