You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/26 11:57:58 UTC

[GitHub] [camel-quarkus] AemieJ opened a new pull request #985: add the auto-generated tabular form for examples page

AemieJ opened a new pull request #985: add the auto-generated tabular form for examples page
URL: https://github.com/apache/camel-quarkus/pull/985
 
 
   * As the example page doesn't include the list of examples in the tabular form, I have made changes to the examples page to include the autogenerated tabular form.
   
   * However, the link to each example is to the `README.adoc` within GitHub itself as there is no separate page for each example. Also, there doesn't exist a `README.adoc` for **timer-log-kotlin**, it direct to the GitHub repo for it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] AemieJ commented on a change in pull request #985: add the auto-generated tabular form for examples page

Posted by GitBox <gi...@apache.org>.
AemieJ commented on a change in pull request #985: add the auto-generated tabular form for examples page
URL: https://github.com/apache/camel-quarkus/pull/985#discussion_r398523034
 
 

 ##########
 File path: docs/modules/ROOT/pages/examples.adoc
 ##########
 @@ -2,3 +2,19 @@
 
 We offer several examples in our https://github.com/apache/camel-quarkus/tree/master/examples[source tree]. To learn
 how to use them, please follow the xref:first-steps.adoc[First steps] chapter of the User guide.
+
+// examples: START
+Number of Examples: 8 (0 deprecated)
+[width="100%",cols="3,7",options="header"]
+|===
+| Example | Description
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/observability/README.adoc[Observability] (observability) | An example that demonstrates how to add support for metrics, health checks and distributed tracing 
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/rest-json/README.adoc[Rest Json] (rest-json) | This example is a port of Quarkus' quickstart to Camel
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log/README.adoc[Timer Log] (timer-log) | An example of basic Hello World that uses a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-cdi/README.adoc[Timer Log CDI] (timer-log-cdi) | An example of basic Hello World that uses CDI to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-kotlin[Timer Log Kotlin] (timer-log-kotlin) | An example of basic Hello World that uses Kotlin to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-xml/README.adoc[Timer Log XML] (timer-log-xml) | An example of basic Hello World that uses XML to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-spring/README.adoc[Timer Log Spring] (timer-log-spring) | An example of basic Hello World that uses Spring to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examplesfile-split-log-xml/README.adoc[File Split Log XML] (file-split-log-xml) | An example of basic Hello World that uses XML to set-up a Camel file consumer
 
 Review comment:
   Which URL? Also for **timer-log-kotlin** there doesn't exist any **README.adoc**

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] ppalaga commented on issue #985: add the auto-generated tabular form for examples page

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #985: add the auto-generated tabular form for examples page
URL: https://github.com/apache/camel-quarkus/pull/985#issuecomment-604908663
 
 
   > > @AemieJ the commit message says auto-generated, but where is the code that generates the table in the commit?
   > 
   > Isn't it the syntax of AsicDoctor that you write the table data in particular syntax and it will provide you with a responsive table design?
   
   Sorry, there is probably some mismatch between you and me in how we understand the term "auto-generated". For me, auto-generated text is an output of some computer program. The list of extensions https://camel.apache.org/camel-quarkus/latest/list-of-camel-quarkus-extensions.html is auto-generated in this sense by the maven plugin located in our repo: https://github.com/apache/camel-quarkus/blob/master/tooling/package-maven-plugin/src/main/java/org/apache/camel/quarkus/maven/UpdateDocExtensionsListMojo.java 
   This approach has the advantage that anytime a new extension is added the list is updated automatically. 
   
   I thought, you were doing something similar for the list of examples. If this was not your aim, I am fine with that, the change is an improvement against the previous state. We do not add new examples that often, so the list can be updated manually. But please remove the word `auto-generated` from the commit message and ideally squash your commits.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] AemieJ commented on issue #985: add the auto-generated tabular form for examples page

Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #985: add the auto-generated tabular form for examples page
URL: https://github.com/apache/camel-quarkus/pull/985#issuecomment-604814318
 
 
   > @AemieJ the commit message says auto-generated, but where is the code that generates the table in the commit?
   
   Isn't it the syntax of AsicDoctor that you write the table data in particular syntax and it will provide you with a responsive table design?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] AemieJ closed pull request #985: add the auto-generated tabular form for examples page

Posted by GitBox <gi...@apache.org>.
AemieJ closed pull request #985: add the auto-generated tabular form for examples page
URL: https://github.com/apache/camel-quarkus/pull/985
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #985: add the auto-generated tabular form for examples page

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #985: add the auto-generated tabular form for examples page
URL: https://github.com/apache/camel-quarkus/pull/985#discussion_r398518819
 
 

 ##########
 File path: docs/modules/ROOT/pages/examples.adoc
 ##########
 @@ -2,3 +2,19 @@
 
 We offer several examples in our https://github.com/apache/camel-quarkus/tree/master/examples[source tree]. To learn
 how to use them, please follow the xref:first-steps.adoc[First steps] chapter of the User guide.
+
+// examples: START
+Number of Examples: 8 (0 deprecated)
+[width="100%",cols="3,7",options="header"]
+|===
+| Example | Description
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/observability/README.adoc[Observability] (observability) | An example that demonstrates how to add support for metrics, health checks and distributed tracing 
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/rest-json/README.adoc[Rest Json] (rest-json) | This example is a port of Quarkus' quickstart to Camel
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log/README.adoc[Timer Log] (timer-log) | An example of basic Hello World that uses a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-cdi/README.adoc[Timer Log CDI] (timer-log-cdi) | An example of basic Hello World that uses CDI to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-kotlin[Timer Log Kotlin] (timer-log-kotlin) | An example of basic Hello World that uses Kotlin to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-xml/README.adoc[Timer Log XML] (timer-log-xml) | An example of basic Hello World that uses XML to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-spring/README.adoc[Timer Log Spring] (timer-log-spring) | An example of basic Hello World that uses Spring to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examplesfile-split-log-xml/README.adoc[File Split Log XML] (file-split-log-xml) | An example of basic Hello World that uses XML to set-up a Camel file consumer
 
 Review comment:
   I think you're missing a '/' in the URL here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #985: add the auto-generated tabular form for examples page

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #985: add the auto-generated tabular form for examples page
URL: https://github.com/apache/camel-quarkus/pull/985#discussion_r398535061
 
 

 ##########
 File path: docs/modules/ROOT/pages/examples.adoc
 ##########
 @@ -2,3 +2,19 @@
 
 We offer several examples in our https://github.com/apache/camel-quarkus/tree/master/examples[source tree]. To learn
 how to use them, please follow the xref:first-steps.adoc[First steps] chapter of the User guide.
+
+// examples: START
+Number of Examples: 8 (0 deprecated)
+[width="100%",cols="3,7",options="header"]
+|===
+| Example | Description
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/observability/README.adoc[Observability] (observability) | An example that demonstrates how to add support for metrics, health checks and distributed tracing 
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/rest-json/README.adoc[Rest Json] (rest-json) | This example is a port of Quarkus' quickstart to Camel
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log/README.adoc[Timer Log] (timer-log) | An example of basic Hello World that uses a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-cdi/README.adoc[Timer Log CDI] (timer-log-cdi) | An example of basic Hello World that uses CDI to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-kotlin[Timer Log Kotlin] (timer-log-kotlin) | An example of basic Hello World that uses Kotlin to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-xml/README.adoc[Timer Log XML] (timer-log-xml) | An example of basic Hello World that uses XML to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-spring/README.adoc[Timer Log Spring] (timer-log-spring) | An example of basic Hello World that uses Spring to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examplesfile-split-log-xml/README.adoc[File Split Log XML] (file-split-log-xml) | An example of basic Hello World that uses XML to set-up a Camel file consumer
 
 Review comment:
   For file-split-log-xml. It has `examplesfile-split-log-xml`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] AemieJ commented on issue #985: add the auto-generated tabular form for examples page

Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #985: add the auto-generated tabular form for examples page
URL: https://github.com/apache/camel-quarkus/pull/985#issuecomment-604913088
 
 
   > > > @AemieJ the commit message says auto-generated, but where is the code that generates the table in the commit?
   > > 
   > > 
   > > Isn't it the syntax of AsicDoctor that you write the table data in particular syntax and it will provide you with a responsive table design?
   > 
   > Sorry, there is probably some mismatch between you and me in how we understand the term "auto-generated". For me, auto-generated text is an output of some computer program. The list of extensions https://camel.apache.org/camel-quarkus/latest/list-of-camel-quarkus-extensions.html is auto-generated in this sense by the maven plugin located in our repo: https://github.com/apache/camel-quarkus/blob/master/tooling/package-maven-plugin/src/main/java/org/apache/camel/quarkus/maven/UpdateDocExtensionsListMojo.java
   > This approach has the advantage that anytime a new extension is added the list is updated automatically.
   > 
   > I thought, you were doing something similar for the list of examples. If this was not your aim, I am fine with that, the change is an improvement against the previous state. We do not add new examples that often, so the list can be updated manually. But please remove the word `auto-generated` from the commit message and ideally squash your commits.
   
   Alright, I have currently made a new PR with a different commit. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] AemieJ commented on a change in pull request #985: add the auto-generated tabular form for examples page

Posted by GitBox <gi...@apache.org>.
AemieJ commented on a change in pull request #985: add the auto-generated tabular form for examples page
URL: https://github.com/apache/camel-quarkus/pull/985#discussion_r398537972
 
 

 ##########
 File path: docs/modules/ROOT/pages/examples.adoc
 ##########
 @@ -2,3 +2,19 @@
 
 We offer several examples in our https://github.com/apache/camel-quarkus/tree/master/examples[source tree]. To learn
 how to use them, please follow the xref:first-steps.adoc[First steps] chapter of the User guide.
+
+// examples: START
+Number of Examples: 8 (0 deprecated)
+[width="100%",cols="3,7",options="header"]
+|===
+| Example | Description
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/observability/README.adoc[Observability] (observability) | An example that demonstrates how to add support for metrics, health checks and distributed tracing 
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/rest-json/README.adoc[Rest Json] (rest-json) | This example is a port of Quarkus' quickstart to Camel
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log/README.adoc[Timer Log] (timer-log) | An example of basic Hello World that uses a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-cdi/README.adoc[Timer Log CDI] (timer-log-cdi) | An example of basic Hello World that uses CDI to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-kotlin[Timer Log Kotlin] (timer-log-kotlin) | An example of basic Hello World that uses Kotlin to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-xml/README.adoc[Timer Log XML] (timer-log-xml) | An example of basic Hello World that uses XML to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-spring/README.adoc[Timer Log Spring] (timer-log-spring) | An example of basic Hello World that uses Spring to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examplesfile-split-log-xml/README.adoc[File Split Log XML] (file-split-log-xml) | An example of basic Hello World that uses XML to set-up a Camel file consumer
 
 Review comment:
   Fixed that problem with the URL.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] ppalaga commented on issue #985: add the auto-generated tabular form for examples page

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #985: add the auto-generated tabular form for examples page
URL: https://github.com/apache/camel-quarkus/pull/985#issuecomment-604676408
 
 
   @AemieJ the commit message says auto-generated, but where is the code that generates the table in the commit?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] AemieJ commented on a change in pull request #985: add the auto-generated tabular form for examples page

Posted by GitBox <gi...@apache.org>.
AemieJ commented on a change in pull request #985: add the auto-generated tabular form for examples page
URL: https://github.com/apache/camel-quarkus/pull/985#discussion_r398536925
 
 

 ##########
 File path: docs/modules/ROOT/pages/examples.adoc
 ##########
 @@ -2,3 +2,19 @@
 
 We offer several examples in our https://github.com/apache/camel-quarkus/tree/master/examples[source tree]. To learn
 how to use them, please follow the xref:first-steps.adoc[First steps] chapter of the User guide.
+
+// examples: START
+Number of Examples: 8 (0 deprecated)
+[width="100%",cols="3,7",options="header"]
+|===
+| Example | Description
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/observability/README.adoc[Observability] (observability) | An example that demonstrates how to add support for metrics, health checks and distributed tracing 
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/rest-json/README.adoc[Rest Json] (rest-json) | This example is a port of Quarkus' quickstart to Camel
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log/README.adoc[Timer Log] (timer-log) | An example of basic Hello World that uses a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-cdi/README.adoc[Timer Log CDI] (timer-log-cdi) | An example of basic Hello World that uses CDI to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-kotlin[Timer Log Kotlin] (timer-log-kotlin) | An example of basic Hello World that uses Kotlin to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-xml/README.adoc[Timer Log XML] (timer-log-xml) | An example of basic Hello World that uses XML to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-spring/README.adoc[Timer Log Spring] (timer-log-spring) | An example of basic Hello World that uses Spring to set-up a Camel timer
+| link:https://github.com/apache/camel-quarkus/tree/master/examplesfile-split-log-xml/README.adoc[File Split Log XML] (file-split-log-xml) | An example of basic Hello World that uses XML to set-up a Camel file consumer
 
 Review comment:
   Thank you, I will fix that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] ppalaga commented on issue #985: add the auto-generated tabular form for examples page

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #985: add the auto-generated tabular form for examples page
URL: https://github.com/apache/camel-quarkus/pull/985#issuecomment-604915630
 
 
   BTW you could do it in the current pull request by squashing them frist https://thoughtbot.com/blog/git-interactive-rebase-squash-amend-rewriting-history and then force pushing to the `examples` in your fork https://stackoverflow.com/questions/10510462/force-git-push-to-overwrite-remote-files That would change the commits in this pull request.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services