You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/03 01:52:54 UTC

[GitHub] [arrow] BryanCutler commented on a change in pull request #7604: ARROW-9223: [Python] Propagate timezone information in pandas conversion

BryanCutler commented on a change in pull request #7604:
URL: https://github.com/apache/arrow/pull/7604#discussion_r449338456



##########
File path: python/pyarrow/tests/test_pandas.py
##########
@@ -3321,9 +3321,12 @@ def test_cast_timestamp_unit():
     assert result.equals(expected)
 
 
-def test_struct_with_timestamp_tz():
+def test_nested_with_timestamp_tz():
     # ARROW-7723
     ts = pd.Timestamp.now()
+    # This is used for verifying timezone conversion to micros are not
+    # important
+    ts_dt = ts.to_pydatetime().replace(microsecond=0)

Review comment:
       I'm not too sure about the failure and the message isn't helpful at all. The test does have a struct with 2 timestamps in it. I should be able to at least get a better error message right now, and then I can look into what's going on.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org