You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/12/21 06:50:07 UTC

[GitHub] [incubator-iceberg] chenjunjiedada commented on a change in pull request #705: Add session catalog for Spark 3.0

chenjunjiedada commented on a change in pull request #705: Add session catalog for Spark 3.0
URL: https://github.com/apache/incubator-iceberg/pull/705#discussion_r360633551
 
 

 ##########
 File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
 ##########
 @@ -99,7 +99,7 @@ protected String name() {
   @Override
   public boolean dropTable(TableIdentifier identifier, boolean purge) {
 
 Review comment:
   Do we need to add `validateTableIsIceberg` in dropTable then catch it and return false?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org