You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/26 17:13:08 UTC

[GitHub] [beam] robertwb commented on a change in pull request #15757: [BEAM-13066, BEAM-13087] Workaround for coder type combiner packing iterable issue on legacy dataflow runner

robertwb commented on a change in pull request #15757:
URL: https://github.com/apache/beam/pull/15757#discussion_r736757062



##########
File path: sdks/python/apache_beam/transforms/combiners.py
##########
@@ -365,6 +365,10 @@ def push(hp, e):
               for element in bundle
           ]
           continue
+        # TODO(robertwb): Remove once legacy dataflow correctly handles

Review comment:
       That is correct; when running in the legacy runner the fact that this should be a list (per its type hint) is lost and it gets an abstract iterable instead. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org