You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/12/16 15:28:47 UTC
[GitHub] [jena] SimonBin opened a new pull request, #1684: resizeable query editor
SimonBin opened a new pull request, #1684:
URL: https://github.com/apache/jena/pull/1684
GitHub issue resolved #
Pull request Description:
a tiny Quality of Live improvement, enable resizeable in the fusekiUI Query editor. That way you can (maybe you still should not!) also view larger queries
Or is there any particular reason why it was disabled?
----
- [ ] Tests are included.
- [ ] Documentation change and updates are provided for the [Apache Jena website](https://github.com/apache/jena-site/)
- [ ] Commits have been squashed to remove intermediate development commit messages.
- [ ] Key commit messages start with the issue number (GH-xxxx or JENA-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
----
See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on pull request #1684: resizeable query editor
Posted by GitBox <gi...@apache.org>.
kinow commented on PR #1684:
URL: https://github.com/apache/jena/pull/1684#issuecomment-1364569180
Finally found time to work on this one. Sorry for the delay. Reviewing it now (but will hold on merging as we have ongoing release candidate works)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on pull request #1684: GH-1693: Resizeable query editor
Posted by GitBox <gi...@apache.org>.
kinow commented on PR #1684:
URL: https://github.com/apache/jena/pull/1684#issuecomment-1364574405
Hi @SimonBin I was going to push to your branch to amend the commit message and add the e2e test, but git said "ERROR: Permission to AKSW/jena.git denied to kinow.". I think you didn't select the option to allow contributors of the project to edit your PR/branch.
Here's the diff for the test. It was fun, I hadn't written a test that required resizing an element yet :slightly_smiling_face:
```diff
diff --git a/jena-fuseki2/jena-fuseki-ui/tests/e2e/specs/query.cy.js b/jena-fuseki2/jena-fuseki-ui/tests/e2e/specs/query.cy.js
index 0e90435a0c..f8a55e4518 100644
--- a/jena-fuseki2/jena-fuseki-ui/tests/e2e/specs/query.cy.js
+++ b/jena-fuseki2/jena-fuseki-ui/tests/e2e/specs/query.cy.js
@@ -76,4 +76,31 @@ describe('Query', () => {
.its('response')
.should('have.property', 'statusCode', 203)
})
+ it('Can resize the query editor', () => {
+ cy.visit('/#/dataset/skosmos/query')
+ cy
+ .get('div.CodeMirror')
+ .should('be.visible')
+ .invoke('css', 'height')
+ .as('beforeHeight')
+ cy
+ .get('div.resizeChip')
+ .should('exist')
+ .trigger('mousedown', {
+ which: 1, force: true
+ })
+ .trigger('mousemove', { which: 1, force: true, x: 0, y: 50 })
+ .trigger('mouseup', {
+ force: true
+ });
+ cy
+ .get('div.CodeMirror')
+ .invoke('css', 'height')
+ .as('afterHeight')
+ cy.get('@beforeHeight').then(beforeHeight => {
+ cy.get('@afterHeight').then(afterHeight => {
+ expect(afterHeight).to.not.equal(beforeHeight)
+ })
+ })
+ })
})
```
Thanks!
@afs tested locally, small change and works fine. Can be merged now or after 4.7.0 :+1:
Thanks @SimonBin !
Bruno
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] SimonBin commented on pull request #1684: GH-1693: Resizeable query editor
Posted by GitBox <gi...@apache.org>.
SimonBin commented on PR #1684:
URL: https://github.com/apache/jena/pull/1684#issuecomment-1366456448
> I think you didn't select the option to allow contributors of the project to edit your PR/branch.
Thanks for the test! I manually added your diff, unfortunately GitHub does not allow maintainer edits for organisation forks...... next time I will create PR from a personal fork, sorry about that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1684: GH-1693: Resizeable query editor
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1684:
URL: https://github.com/apache/jena/pull/1684#issuecomment-1374504432
The development flood gates are open ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1684: GH-1693: Resizeable query editor
Posted by GitBox <gi...@apache.org>.
afs merged PR #1684:
URL: https://github.com/apache/jena/pull/1684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org