You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stanbol.apache.org by Fabian Christ <ch...@googlemail.com> on 2011/02/18 13:28:43 UTC
Re: svn commit: r1071915 - /incubator/stanbol/trunk/kres/eu.iksproject.kres.rules/src/main/resources/META-INF/conf/rmi_config.owl
Hi Elvio,
commit message should explain what changes were made to the code
within a particular commit. This makes is much easier to review
changes and to understand what is going on in the code by just reading
the commit messages. So a commit message like this, which just copies
the text from the JIRA issue, is not that helpful. As discussed on the
list a few weeks ago, we should start each commit message with the
corresponding STANBOL-XXX issue but the message itself should be an
individual one.
This is just to inform about the best practices here. Thank you very
much for your work on KReS!
Best,
- Fabian
2011/2/18 <co...@apache.org>:
> Author: concelvio
> Date: Fri Feb 18 08:27:33 2011
> New Revision: 1071915
>
> URL: http://svn.apache.org/viewvc?rev=1071915&view=rev
> Log:
> STANBOL-100
> 1) There is the sequence of rules for recipe MyRecipeA with a wrong prefix.
> Issue #STANBOL-100 - Ontology rmi_config.owl used for test has an individual with a wrong prefix.
>
> Modified:
> incubator/stanbol/trunk/kres/eu.iksproject.kres.rules/src/main/resources/META-INF/conf/rmi_config.owl
>
> Modified: incubator/stanbol/trunk/kres/eu.iksproject.kres.rules/src/main/resources/META-INF/conf/rmi_config.owl
> URL: http://svn.apache.org/viewvc/incubator/stanbol/trunk/kres/eu.iksproject.kres.rules/src/main/resources/META-INF/conf/rmi_config.owl?rev=1071915&r1=1071914&r2=1071915&view=diff
> ==============================================================================
> --- incubator/stanbol/trunk/kres/eu.iksproject.kres.rules/src/main/resources/META-INF/conf/rmi_config.owl (original)
> +++ incubator/stanbol/trunk/kres/eu.iksproject.kres.rules/src/main/resources/META-INF/conf/rmi_config.owl Fri Feb 18 08:27:33 2011
> @@ -128,7 +128,7 @@
> <owl:NamedIndividual rdf:about="http://kres.iks-project.eu/ontology/meta/rmi_config.owl#MyRecipeA">
> <rdf:type rdf:resource="&rmi;Recipe"/>
> <rmi:hasDescription rdf:datatype="&xsd;string">Some description here</rmi:hasDescription>
> - <rmi:hasSequence rdf:datatype="&xsd;string">http://eu.iksproject.kres/KReSOntologyRules.owl#MyRuleB,http://eu.iksproject.kres/KReSOntologyRules.owl#MyRuleA</rmi:hasSequence>
> + <rmi:hasSequence rdf:datatype="&xsd;string">http://kres.iks-project.eu/ontology/meta/rmi_config.owl#MyRuleB,http://kres.iks-project.eu/ontology/meta/rmi_config.owl#MyRuleA</rmi:hasSequence>
> <rmi:hasRule rdf:resource="http://kres.iks-project.eu/ontology/meta/rmi_config.owl#MyRuleA"/>
> <rmi:endWith rdf:resource="http://kres.iks-project.eu/ontology/meta/rmi_config.owl#MyRuleA"/>
> <rmi:hasRule rdf:resource="http://kres.iks-project.eu/ontology/meta/rmi_config.owl#MyRuleB"/>
>
>
>
--
Fabian
Re: svn commit: r1071915 - /incubator/stanbol/trunk/kres/eu.iksproject.kres.rules/src/main/resources/META-INF/conf/rmi_config.owl
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Fri, Feb 18, 2011 at 1:59 PM, Fabian Christ
<ch...@googlemail.com> wrote:
> ...Okay cool. I'm just wondering what happens if I use more then one
> STANBOL-XXX in the text? Will the commit appear in each issue?...
Yes, see for example
https://issues.apache.org/jira/browse/STANBOL-19
https://issues.apache.org/jira/browse/SLING-1981
which both mention revision 1071577
-Bertrand
Re: svn commit: r1071915 - /incubator/stanbol/trunk/kres/eu.iksproject.kres.rules/src/main/resources/META-INF/conf/rmi_config.owl
Posted by Fabian Christ <ch...@googlemail.com>.
Hi,
2011/2/18 Bertrand Delacretaz <bd...@apache.org>:
> Hi,
>
> On Fri, Feb 18, 2011 at 1:28 PM, Fabian Christ
> <ch...@googlemail.com> wrote:
>> ...As discussed on the
>> list a few weeks ago, we should start each commit message with the
>> corresponding STANBOL-XXX issue but the message itself should be an
>> individual one....
>
> In the meantime, maybe due to the recent JIRA upgrade, I found out
> that STANBOL-XXX does not need to be at the beginning of the commit
> message, if it's in the middle that works as well (*). But in general
> I like starting my commit messages with that.
Okay cool. I'm just wondering what happens if I use more then one
STANBOL-XXX in the text? Will the commit appear in each issue?
Best,
- Fabian
--
Fabian
Re: svn commit: r1071915 - /incubator/stanbol/trunk/kres/eu.iksproject.kres.rules/src/main/resources/META-INF/conf/rmi_config.owl
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Fri, Feb 18, 2011 at 1:28 PM, Fabian Christ
<ch...@googlemail.com> wrote:
> ...As discussed on the
> list a few weeks ago, we should start each commit message with the
> corresponding STANBOL-XXX issue but the message itself should be an
> individual one....
In the meantime, maybe due to the recent JIRA upgrade, I found out
that STANBOL-XXX does not need to be at the beginning of the commit
message, if it's in the middle that works as well (*). But in general
I like starting my commit messages with that.
-Bertrand
(*) "works" meaning the commit comments appear in the corresponding
JIRA issue page, like
https://issues.apache.org/jira/browse/STANBOL-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel#issue-tabs