You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by sh...@apache.org on 2013/09/09 21:30:51 UTC
svn commit: r1521258 -
/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexFileDeleter.java
Author: shaie
Date: Mon Sep 9 19:30:51 2013
New Revision: 1521258
URL: http://svn.apache.org/r1521258
Log:
Make IndexFileDeleter.lastFiles a List<String> instead of List<Collection<String>>
Modified:
lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexFileDeleter.java
Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexFileDeleter.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexFileDeleter.java?rev=1521258&r1=1521257&r2=1521258&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexFileDeleter.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexFileDeleter.java Mon Sep 9 19:30:51 2013
@@ -92,7 +92,7 @@ final class IndexFileDeleter implements
/* Holds files we had incref'd from the previous
* non-commit checkpoint: */
- private List<Collection<String>> lastFiles = new ArrayList<Collection<String>>();
+ private final List<String> lastFiles = new ArrayList<String>();
/* Commits that the IndexDeletionPolicy have decided to delete: */
private List<CommitPoint> commitsToDelete = new ArrayList<CommitPoint>();
@@ -361,14 +361,13 @@ final class IndexFileDeleter implements
refresh(null);
}
+ @Override
public void close() throws IOException {
// DecRef old files from the last checkpoint, if any:
assert locked();
- int size = lastFiles.size();
- if (size > 0) {
- for(int i=0;i<size;i++) {
- decRef(lastFiles.get(i));
- }
+
+ if (!lastFiles.isEmpty()) {
+ decRef(lastFiles);
lastFiles.clear();
}
@@ -459,13 +458,11 @@ final class IndexFileDeleter implements
deleteCommits();
} else {
// DecRef old files from the last checkpoint, if any:
- for (Collection<String> lastFile : lastFiles) {
- decRef(lastFile);
- }
+ decRef(lastFiles);
lastFiles.clear();
// Save files so we can decr on next checkpoint/commit:
- lastFiles.add(segmentInfos.files(directory, false));
+ lastFiles.addAll(segmentInfos.files(directory, false));
}
if (infoStream.isEnabled("IFD")) {
long t1 = System.nanoTime();