You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by rf...@apache.org on 2019/01/19 15:23:28 UTC

[maven-jmod-plugin] branch refactor updated: Cleanup code

This is an automated email from the ASF dual-hosted git repository.

rfscholte pushed a commit to branch refactor
in repository https://gitbox.apache.org/repos/asf/maven-jmod-plugin.git


The following commit(s) were added to refs/heads/refactor by this push:
     new 8f48db3  Cleanup code
8f48db3 is described below

commit 8f48db386308f76a00bcb3549962aba29cc5ab82
Author: rfscholte <rf...@apache.org>
AuthorDate: Sat Jan 19 16:23:22 2019 +0100

    Cleanup code
---
 .../apache/maven/plugins/jmod/JModCreateMojo.java  | 36 ----------------------
 1 file changed, 36 deletions(-)

diff --git a/src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java b/src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java
index 03c0a3f..295b079 100644
--- a/src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java
+++ b/src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java
@@ -317,41 +317,6 @@ public class JModCreateMojo
         // create the jmods folder...
         modsFolder.mkdirs();
 
-//        this.modulePaths = new ArrayList<>();
-
-//        if ( pathElements != null && !pathElements.isEmpty() )
-//        {
-//            for ( Entry<String, JavaModuleDescriptor> item : pathElements.entrySet() )
-//            {
-//                // Isn't there a better solution?
-//                if ( item.getValue() == null )
-//                {
-//                    String message = "The given dependency " + item.getKey()
-//                            + " does not have a module-info.java file. So it can't be linked.";
-//                    getLog().error( message );
-//                    throw new MojoFailureException( message );
-//                }
-//                getLog().debug( "pathElements Item:" + item.getKey() + " v:" + item.getValue().name() );
-//                getLog().info( " -> module: " + item.getValue().name() + " ( " + item.getKey() + " )" );
-//                // We use the real module name and not the artifact Id...
-//                this.modulePaths.add( item.getKey() );
-//            }
-//        }
-//        else
-//        {
-//            StringBuilder builder = new StringBuilder();
-//            int i = 0;
-//            for ( Artifact artifact : getProject().getDependencyArtifacts() )
-//            {
-//                builder.append( artifact.getFile().getAbsolutePath() );
-//                if ( ++i < getProject().getDependencyArtifacts().size() )
-//                {
-//                    builder.append( File.pathSeparatorChar );
-//                }
-//            }
-//            classPath = builder.toString();
-//        }
-
         Commandline cmd;
         try
         {
@@ -539,7 +504,6 @@ public class JModCreateMojo
             {
                 getLog().warn( e.getMessage() );
             }
-
         }
         else
         {