You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by we...@apache.org on 2017/03/21 04:21:22 UTC
reef git commit: [REEF-1622] Fix
TestKMeansOnLocalRuntimeWithGroupCommunications failures in AppVeyor
Repository: reef
Updated Branches:
refs/heads/master 9a9715f91 -> 9fdaed216
[REEF-1622] Fix TestKMeansOnLocalRuntimeWithGroupCommunications failures in AppVeyor
The test fails sometimes in AppVeyor. As the contexts are not explicitly closed
right after ICompletedTask event is received, it may cause some delay for
context to be closed which is where the test fails.
JIRA:
[REEF-1622](https://issues.apache.org/jira/browse/REEF-1622)
Pull Request:
This closes #1266
Project: http://git-wip-us.apache.org/repos/asf/reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/9fdaed21
Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/9fdaed21
Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/9fdaed21
Branch: refs/heads/master
Commit: 9fdaed2161bd1c9ec60acb0822028e410b0ed966
Parents: 9a9715f
Author: Julia Wang <ju...@apache.org>
Authored: Thu Mar 16 18:22:56 2017 -0700
Committer: Markus Weimer <we...@apache.org>
Committed: Mon Mar 20 21:20:12 2017 -0700
----------------------------------------------------------------------
.../MachineLearning/KMeans/KMeansDriverHandlers.cs | 11 ++++++++---
.../Functional/ML/KMeans/TestKMeans.cs | 13 +++++++------
2 files changed, 15 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/reef/blob/9fdaed21/lang/cs/Org.Apache.REEF.Examples/MachineLearning/KMeans/KMeansDriverHandlers.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Examples/MachineLearning/KMeans/KMeansDriverHandlers.cs b/lang/cs/Org.Apache.REEF.Examples/MachineLearning/KMeans/KMeansDriverHandlers.cs
index 6ae60bd..b01065d 100644
--- a/lang/cs/Org.Apache.REEF.Examples/MachineLearning/KMeans/KMeansDriverHandlers.cs
+++ b/lang/cs/Org.Apache.REEF.Examples/MachineLearning/KMeans/KMeansDriverHandlers.cs
@@ -25,6 +25,7 @@ using Org.Apache.REEF.Driver;
using Org.Apache.REEF.Driver.Bridge;
using Org.Apache.REEF.Driver.Context;
using Org.Apache.REEF.Driver.Evaluator;
+using Org.Apache.REEF.Driver.Task;
using Org.Apache.REEF.Examples.MachineLearning.KMeans.codecs;
using Org.Apache.REEF.Network.Group.Config;
using Org.Apache.REEF.Network.Group.Driver;
@@ -45,7 +46,8 @@ namespace Org.Apache.REEF.Examples.MachineLearning.KMeans
public class KMeansDriverHandlers :
IObserver<IAllocatedEvaluator>,
IObserver<IActiveContext>,
- IObserver<IDriverStarted>
+ IObserver<IDriverStarted>,
+ IObserver<ICompletedTask>
{
private static readonly Logger _Logger = Logger.GetLogger(typeof(KMeansDriverHandlers));
private readonly object _lockObj = new object();
@@ -192,12 +194,15 @@ namespace Org.Apache.REEF.Examples.MachineLearning.KMeans
public void OnError(Exception error)
{
- throw new NotImplementedException();
}
public void OnCompleted()
{
- throw new NotImplementedException();
+ }
+
+ public void OnNext(ICompletedTask value)
+ {
+ value.ActiveContext.Dispose();
}
}
http://git-wip-us.apache.org/repos/asf/reef/blob/9fdaed21/lang/cs/Org.Apache.REEF.Tests/Functional/ML/KMeans/TestKMeans.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tests/Functional/ML/KMeans/TestKMeans.cs b/lang/cs/Org.Apache.REEF.Tests/Functional/ML/KMeans/TestKMeans.cs
index a1cc91c..4cc91ff 100644
--- a/lang/cs/Org.Apache.REEF.Tests/Functional/ML/KMeans/TestKMeans.cs
+++ b/lang/cs/Org.Apache.REEF.Tests/Functional/ML/KMeans/TestKMeans.cs
@@ -123,7 +123,7 @@ namespace Org.Apache.REEF.Tests.Functional.ML.KMeans
string dataFilePath = GenerateDataFileAndGetPath();
TestRun(DriverConfiguration(dataFilePath), typeof(KMeansDriverHandlers), Partitions + 1, "KMeansDriverHandlers", "local", testFolder);
- ValidateSuccessForLocalRuntime(Partitions + 1, testFolder: testFolder);
+ ValidateSuccessForLocalRuntime(Partitions + 1, testFolder: testFolder, retryCount: 120);
CleanUp(testFolder);
try
{
@@ -156,11 +156,12 @@ namespace Org.Apache.REEF.Tests.Functional.ML.KMeans
IConfiguration driverConfig = TangFactory.GetTang().NewConfigurationBuilder(
Org.Apache.REEF.Driver.DriverConfiguration.ConfigurationModule
- .Set(Org.Apache.REEF.Driver.DriverConfiguration.OnDriverStarted, GenericType<KMeansDriverHandlers>.Class)
- .Set(Org.Apache.REEF.Driver.DriverConfiguration.OnEvaluatorAllocated, GenericType<KMeansDriverHandlers>.Class)
- .Set(Org.Apache.REEF.Driver.DriverConfiguration.OnContextActive, GenericType<KMeansDriverHandlers>.Class)
- .Set(Org.Apache.REEF.Driver.DriverConfiguration.CommandLineArguments, dataFilePath)
- .Set(Org.Apache.REEF.Driver.DriverConfiguration.CustomTraceLevel, Level.Info.ToString())
+ .Set(REEF.Driver.DriverConfiguration.OnDriverStarted, GenericType<KMeansDriverHandlers>.Class)
+ .Set(REEF.Driver.DriverConfiguration.OnEvaluatorAllocated, GenericType<KMeansDriverHandlers>.Class)
+ .Set(REEF.Driver.DriverConfiguration.OnContextActive, GenericType<KMeansDriverHandlers>.Class)
+ .Set(REEF.Driver.DriverConfiguration.OnTaskCompleted, GenericType<KMeansDriverHandlers>.Class)
+ .Set(REEF.Driver.DriverConfiguration.CommandLineArguments, dataFilePath)
+ .Set(REEF.Driver.DriverConfiguration.CustomTraceLevel, Level.Info.ToString())
.Build())
.BindIntNamedParam<NumPartitions>(Partitions.ToString())
.Build();