[GitHub] [samza] ryucc commented on a diff in pull request #1651: Migrate zkclient library

["ryucc (via GitHub)" <gi...@apache.org>]

ryucc commented on code in PR #1651:
URL: https://github.com/apache/samza/pull/1651#discussion_r1087123297


##########
samza-core/src/main/java/org/apache/samza/zk/ZkLeaderElector.java:
##########
@@ -69,6 +71,7 @@ public ZkLeaderElector(String processorIdStr, ZkUtils zkUtils) {
   @VisibleForTesting
   public ZkLeaderElector(String processorIdStr,
                          ZkUtils zkUtils,
+                         @Nonnull
                          IZkDataListener previousProcessorChangeListener) {
     this.processorIdStr = processorIdStr;

Review Comment:
   Another way to do this to add a null check, and call `ZkLeaderElector(String processorIdStr ZkUtils zkUtils)` if null.
   
   There are no internal callers that pass in null here, except our unit tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org