[GitHub] [cassandra] frankgh commented on a diff in pull request #1701: CASSANDRA-17677: Fix BulkLoader to load entireSSTableThrottle and entireSSTableInterDcThrottle

[GitBox <gi...@apache.org>]

frankgh commented on code in PR #1701:
URL: https://github.com/apache/cassandra/pull/1701#discussion_r914038188


##########
src/java/org/apache/cassandra/tools/LoaderOptions.java:
##########
@@ -60,10 +72,14 @@
     public static final String IGNORE_NODES_OPTION = "ignore";
     public static final String CONNECTIONS_PER_HOST = "connections-per-host";
     public static final String CONFIG_PATH = "conf-path";
-    public static final String THROTTLE_MBITS = "throttle";
-    public static final String INTER_DC_THROTTLE_MBITS = "inter-dc-throttle";
-    public static final String ENTIRE_SSTABLE_THROTTLE_MBITS = "entire-sstable-throttle";
-    public static final String ENTIRE_SSTABLE_INTER_DC_THROTTLE_MBITS = "entire-sstable-inter-dc-throttle";
+    @Deprecated
+    public static final String THROTTLE_MEGABITS = "throttle";

Review Comment:
   I think it's best to keep the original name, since Cassandra could sometimes be used as a library. I will add the comment and I will retain the `@Deprecated` annotation as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org