You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "owenwillison-vajra (via GitHub)" <gi...@apache.org> on 2026/08/09 12:57:41 UTC
[PR] Fix flaky trace snapshot fallback tests by awaiting manifest persistence [skywalking-banyandb]
owenwillison-vajra opened a new pull request, #1270:
URL: https://github.com/apache/skywalking-banyandb/pull/1270
## Summary
- wait for the trace snapshot manifest before closing the table in snapshot fallback tests
- remove the sleep and premature part-directory readiness check from both affected tests
## Root cause
The tests assumed that a part directory meant the asynchronous flush was complete. That directory is created before the flushed part is introduced and before its snapshot manifest is persisted, so closing the table could cancel the flusher and leave the fixture without a valid snapshot. The parse warnings in the failure log came from the corrupt snapshots deliberately created by the tests and were not partial production writes.
## Testing
- 200 race-enabled repetitions of both trace snapshot fallback tests
- `make lint`
- `make check` license and formatting stages; its clean-tree assertion detected only the intentional test-file change
No production lifecycle behavior was changed.
Flaky-Test: github.com/apache/skywalking-banyandb/banyand/trace.TestTraceTolerantLoaderFallbackToOlderSnapshot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix flaky trace snapshot fallback tests by awaiting manifest persistence [skywalking-banyandb]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily closed pull request #1270: Fix flaky trace snapshot fallback tests by awaiting manifest persistence
URL: https://github.com/apache/skywalking-banyandb/pull/1270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix flaky trace snapshot fallback tests by awaiting manifest persistence [skywalking-banyandb]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1270:
URL: https://github.com/apache/skywalking-banyandb/pull/1270#issuecomment-5236304290
## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/1270?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 46.84%. Comparing base ([`3530dd9`](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/3530dd9b5cefaa4fef60eec91ecbfbdfcaf243c5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`658f5cf`](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/658f5cff814a1925f75947198a10d1b931ff9c2a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 372 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
+ Coverage 45.97% 46.84% +0.86%
==========================================
Files 328 244 -84
Lines 55505 22676 -32829
==========================================
- Hits 25520 10622 -14898
+ Misses 27909 10991 -16918
+ Partials 2076 1063 -1013
```
| [Flag](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/1270/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/1270/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.84% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/1270?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org