You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by cz...@apache.org on 2007/03/05 15:12:46 UTC
svn commit: r514671 -
/cocoon/trunk/blocks/cocoon-repository/cocoon-repository-impl/src/test/java/org/apache/cocoon/components/source/impl/CachingSourceTestCase.java
Author: cziegeler
Date: Mon Mar 5 06:12:44 2007
New Revision: 514671
URL: http://svn.apache.org/viewvc?view=rev&rev=514671
Log:
Fix test case
Modified:
cocoon/trunk/blocks/cocoon-repository/cocoon-repository-impl/src/test/java/org/apache/cocoon/components/source/impl/CachingSourceTestCase.java
Modified: cocoon/trunk/blocks/cocoon-repository/cocoon-repository-impl/src/test/java/org/apache/cocoon/components/source/impl/CachingSourceTestCase.java
URL: http://svn.apache.org/viewvc/cocoon/trunk/blocks/cocoon-repository/cocoon-repository-impl/src/test/java/org/apache/cocoon/components/source/impl/CachingSourceTestCase.java?view=diff&rev=514671&r1=514670&r2=514671
==============================================================================
--- cocoon/trunk/blocks/cocoon-repository/cocoon-repository-impl/src/test/java/org/apache/cocoon/components/source/impl/CachingSourceTestCase.java (original)
+++ cocoon/trunk/blocks/cocoon-repository/cocoon-repository-impl/src/test/java/org/apache/cocoon/components/source/impl/CachingSourceTestCase.java Mon Mar 5 06:12:44 2007
@@ -82,14 +82,18 @@
CachingSource.SourceMeta meta2 = source.getResponseMeta();
resolver.release(source);
- assertTrue(meta1 == meta2);
+ assertTrue(meta1.getMimeType() == meta2.getMimeType());
+ assertTrue(meta1.getContentLength() == meta2.getContentLength());
+ assertTrue(meta1.getLastModified() == meta2.getLastModified());
source = (CachingSource) resolver.resolveURI(uri);
source.refresh();
CachingSource.SourceMeta meta3 = source.getResponseMeta();
resolver.release(source);
- assertTrue(meta1 == meta3);
+ assertTrue(meta1.getMimeType() == meta3.getMimeType());
+ assertTrue(meta1.getContentLength() == meta3.getContentLength());
+ assertTrue(meta1.getLastModified() == meta3.getLastModified());
Thread.sleep(1100);
Re: svn commit: r514671 - /cocoon/trunk/blocks/cocoon-repository/cocoon-repository-impl/src/test/java/org/apache/cocoon/components/source/impl/CachingSourceTestCase.java
Posted by Carsten Ziegeler <cz...@apache.org>.
Vadim Gritsenko wrote:
> Vadim Gritsenko wrote:
>> cziegeler@apache.org wrote:
>>> - assertTrue(meta1 == meta2);
>>> + assertTrue(meta1.getMimeType() == meta2.getMimeType());
>>> + assertTrue(meta1.getContentLength() ==
>>> meta2.getContentLength());
>>> + assertTrue(meta1.getLastModified() == meta2.getLastModified());
>> Looks like caching source ain't working correctly anymore. It should be
>> returning same (cached) objects.
>
> It does, test works.
>
Thanks to your latest fix, it works now here as well :)
Great!
Carsten
--
Carsten Ziegeler
http://www.osoco.org/weblogs/rael/
Re: svn commit: r514671 - /cocoon/trunk/blocks/cocoon-repository/cocoon-repository-impl/src/test/java/org/apache/cocoon/components/source/impl/CachingSourceTestCase.java
Posted by Vadim Gritsenko <va...@reverycodes.com>.
Vadim Gritsenko wrote:
> cziegeler@apache.org wrote:
>> - assertTrue(meta1 == meta2);
>> + assertTrue(meta1.getMimeType() == meta2.getMimeType());
>> + assertTrue(meta1.getContentLength() ==
>> meta2.getContentLength());
>> + assertTrue(meta1.getLastModified() == meta2.getLastModified());
>
> Looks like caching source ain't working correctly anymore. It should be
> returning same (cached) objects.
It does, test works.
Vadim
Re: svn commit: r514671 - /cocoon/trunk/blocks/cocoon-repository/cocoon-repository-impl/src/test/java/org/apache/cocoon/components/source/impl/CachingSourceTestCase.java
Posted by Vadim Gritsenko <va...@reverycodes.com>.
cziegeler@apache.org wrote:
> - assertTrue(meta1 == meta2);
> + assertTrue(meta1.getMimeType() == meta2.getMimeType());
> + assertTrue(meta1.getContentLength() == meta2.getContentLength());
> + assertTrue(meta1.getLastModified() == meta2.getLastModified());
Looks like caching source ain't working correctly anymore. It should be
returning same (cached) objects.
Vadim