[GitHub] [superset] pkdotson commented on a change in pull request #14463: refactor: refactor Icon to Icons in sqlEditor component

[GitBox <gi...@apache.org>]

pkdotson commented on a change in pull request #14463:
URL: https://github.com/apache/superset/pull/14463#discussion_r652185514



##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -638,7 +638,9 @@ class SqlEditor extends React.PureComponent {
                         this.props.defaultQueryLimit,
                     )}
                   </span>
-                  <Icon name="triangle-down" />
+                  <Icons.TriangleDown
+                    iconColor={supersetTheme.colors.grayscale.base}

Review comment:
       Will leave the icon color for now as we come up with a solution for default color for icons




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org