You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by "wang384670111 (via GitHub)" <gi...@apache.org> on 2023/03/31 15:59:14 UTC
[GitHub] [incubator-teaclave-sgx-sdk] wang384670111 opened a new pull request, #428: modified atomic::ordering about SHOULD_CAPTURE
wang384670111 opened a new pull request, #428:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/428
https://github.com/wang384670111/incubator-teaclave-sgx-sdk/blob/780dc8999477244d8ff1e6f418321adbec51ee58/sgx_tstd/src/panic.rs#L261
https://github.com/wang384670111/incubator-teaclave-sgx-sdk/blob/780dc8999477244d8ff1e6f418321adbec51ee58/sgx_tstd/src/panic.rs#L287
I think the use of ordering here is irregular, SHOULD_CAPYURE is used not to synchronize access to other shared variables. I think just Ordering::Relaxed needs to be used here to ensure the correctness of the program.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave-sgx-sdk] volcano0dr commented on pull request #428: modified atomic::ordering about SHOULD_CAPTURE
Posted by "volcano0dr (via GitHub)" <gi...@apache.org>.
volcano0dr commented on PR #428:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/428#issuecomment-1498916931
@wang384670111 Thanks for reporting this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org