[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1952: IGNITE-19290 Removing garbage from the partition, taking into account the safe time

["ibessonov (via GitHub)" <gi...@apache.org>]

ibessonov commented on code in PR #1952:
URL: https://github.com/apache/ignite-3/pull/1952#discussion_r1182169969


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -221,7 +228,8 @@ private void handleUpdateCommand(UpdateCommand cmd, long commandIndex, long comm
                     txsPendingRowIds.computeIfAbsent(cmd.txId(), entry -> new HashSet<>()).add(rowId);
 
                     storage.lastApplied(commandIndex, commandTerm);
-                }
+                },
+                lowWatermarkSupplier.get()

Review Comment:
   New ticket is good. We should compromise components responsibilities due to problems with copy-paste, it should be handled differently



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org