[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5183: TP: converts delivery service requests table to ag-grid

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #5183:
URL: https://github.com/apache/trafficcontrol/pull/5183#discussion_r514597725



##########
File path: traffic_portal/app/src/common/modules/table/jobs/TableJobsController.js
##########
@@ -80,8 +80,6 @@ var TableJobsController = function(tableName, jobs, $document, $scope, $state, $
 			x.expires = new Date(x.startTime.getTime() + ttl*3600*1000);
 		});
 
-	$scope.jobs = jobs;

Review comment:
       why?

##########
File path: traffic_ops/traffic_ops_golang/deliveryservice/request/requests.go
##########
@@ -92,6 +92,7 @@ func (req *TODeliveryServiceRequest) Read(h http.Header, useIMS bool) ([]interfa
 		"author":     dbhelpers.WhereColumnInfo{Column: "a.username"},
 		"authorId":   dbhelpers.WhereColumnInfo{Column: "r.author_id", Checker: api.IsInt},
 		"changeType": dbhelpers.WhereColumnInfo{Column: "r.change_type"},
+		"createdAt":  dbhelpers.WhereColumnInfo{Column: "r.created_at"},

Review comment:
       if you're adding a query parameter, each affected version will need a documentation update.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org