You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/17 18:52:59 UTC
[jira] [Commented] (THRIFT-3977) PHP extension creates undefined
values when deserializing sets
[ https://issues.apache.org/jira/browse/THRIFT-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15674510#comment-15674510 ]
ASF GitHub Bot commented on THRIFT-3977:
----------------------------------------
GitHub user zhaakhi opened a pull request:
https://github.com/apache/thrift/pull/1133
THRIFT-3977 PHP extension creates undefined values when deserializing…
… sets
Fix to set values to 'true' instead of undefined, matching the comment
and old behaviour.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhaakhi/thrift THRIFT-3977
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1133.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1133
----
commit b2341fc743fb212ef78c61eedcef2508f7d6a8e4
Author: Håkon H. Hitland <ha...@likedan.net>
Date: 2016-11-17T18:37:37Z
THRIFT-3977 PHP extension creates undefined values when deserializing sets
Fix to set values to 'true' instead of undefined, matching the comment
and old behaviour.
----
> PHP extension creates undefined values when deserializing sets
> --------------------------------------------------------------
>
> Key: THRIFT-3977
> URL: https://issues.apache.org/jira/browse/THRIFT-3977
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
> Reporter: Håkon Hitland
>
> The PHP binary protocol acceleration extension does not deserialize sets correctly for PHP 7.
> It should be setting the value to "true", but instead sets them to an undefined value. This causes strange behaviour in PHP, like arrays with size > 0 that compare equal to the empty array.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)