You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/08 01:25:50 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #7143: [WIP] Broker Interceptors

sijie commented on a change in pull request #7143:
URL: https://github.com/apache/pulsar/pull/7143#discussion_r436422516



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -1769,6 +1783,20 @@
     )
     private Set<String> brokerClientTlsProtocols = Sets.newTreeSet();
 
+    /**** --- Interceptor variables --- ****/
+
+    @FieldContext(
+        category = CATEGORY_INTERCEPTORS,
+        doc = "The directory to locate interceptors"
+    )
+    private String interceptorDirectory = "./interceptors";

Review comment:
       overall looks good to me. I see there are two sets of settings here, one is for `listeners` and the other one is for `interceptors`? I think we should just rename the listener interfaces to Interceptors. So it is consistent with client-side interceptor.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org