[jira] [Commented] (HADOOP-13300) maven-jar-plugin executions break build with newer plugin

["Christopher Tubbs (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-13300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15340570#comment-15340570 ] 

Christopher Tubbs commented on HADOOP-13300:
--------------------------------------------

In some of the cases, it looks like the main jar artifact is being created earlier in the build lifecycle so it is available for tests. In these cases, it might be acceptable to override (or skip) the default execution of the maven-jar-plugin, but it's probably better to omit the custom execution, and instead move the tests to the integration-test phases, which exists for this purpose.

> maven-jar-plugin executions break build with newer plugin
> ---------------------------------------------------------
>
>                 Key: HADOOP-13300
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13300
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>            Reporter: Christopher Tubbs
>
> Several places throughout the Hadoop build (going back at least as far as 2.4.1; I didn't check earlier), extra executions of maven-jar-plugin have been used to create jars at different phases in the build lifecycle.
> These have typically not specified an execution id, but should have specified "default-jar" to override the default execution of maven-jar-plugin. They have worked in the past because maven-jar-plugin didn't check to verify if an artifact was built/attached multiple times (without using a classifier), but will not work when a newer version of maven-jar-plugin is used (>3.0), which is more strict about checking.
> This is a problem for any downstream packagers which are using newer versions of build plugins (due to dependency convergence) and will become a problem when Hadoop moves to a newer version of the jar plugin (with ASF Parent POM 18, for example).
> [These are the ones I've found|https://lists.apache.org/thread.html/2c9d9ea5448a3ed22743916d20e40a9e589bfa383c8ea65f35cb3f0d@%3Cuser.hadoop.apache.org%3E].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org