[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9247: feat: support store route's cert in secrets manager

["monkeyDluffy6017 (via GitHub)" <gi...@apache.org>]

monkeyDluffy6017 commented on code in PR #9247:
URL: https://github.com/apache/apisix/pull/9247#discussion_r1159887289


##########
apisix/schema_def.lua:
##########
@@ -725,8 +725,19 @@ _M.ssl = {
             default = "server",
             enum = {"server", "client"}
         },
-        cert = certificate_scheme,
-        key = private_key_schema,
+        cert = {
+            oneOf = {
+                { type = "string", minLength = 128, maxLength = 64*1024},
+                -- TODO: uniformly define the schema of secret_uri
+                { type = "string", pattern = "^\\$secret://"}

Review Comment:
   Does this could work?
   ```
           cert = {
               oneOf = {
                   certificate_scheme,
                   { type = "string", pattern = "^\\$secret://"}
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org