You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/07 09:47:01 UTC
[GitHub] [flink] twalthr commented on a change in pull request #18274: [FLINK-25230][table-planner] Harden type serialization for LogicalType and DataType
twalthr commented on a change in pull request #18274:
URL: https://github.com/apache/flink/pull/18274#discussion_r780140261
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/utils/LogicalTypeDataTypeConverter.java
##########
@@ -201,9 +200,29 @@ public DataType visit(RowType rowType) {
@Override
public DataType visit(DistinctType distinctType) {
- return new FieldsDataType(
- distinctType,
- Collections.singletonList(distinctType.getSourceType().accept(this)));
+ final DataType sourceDataType = distinctType.getSourceType().accept(this);
+ if (sourceDataType instanceof AtomicDataType) {
+ return new AtomicDataType(distinctType, sourceDataType.getConversionClass());
+ } else if (sourceDataType instanceof CollectionDataType) {
+ final CollectionDataType collectionDataType = (CollectionDataType) sourceDataType;
+ return new CollectionDataType(
+ distinctType,
+ collectionDataType.getConversionClass(),
+ collectionDataType.getElementDataType());
+ } else if (sourceDataType instanceof KeyValueDataType) {
+ final KeyValueDataType keyValueDataType = (KeyValueDataType) sourceDataType;
+ return new KeyValueDataType(
+ distinctType,
+ keyValueDataType.getConversionClass(),
+ keyValueDataType.getKeyDataType(),
+ keyValueDataType.getValueDataType());
+ } else if (sourceDataType instanceof FieldsDataType) {
+ return new FieldsDataType(
+ distinctType,
+ sourceDataType.getConversionClass(),
+ sourceDataType.getChildren());
+ }
+ throw new IllegalStateException("Unexpected data type instance.");
Review comment:
The outer data type needs to preserve the original `distinctType` LogicalType. However, distinct types should behave similar as the source type when it comes to accessing elements and fields. Therefore, they also need to have a similar DataType wrapper class such as `FieldsDataType` or `KeyValueDataType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org