You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/14 00:38:33 UTC
[GitHub] [flink] bowenli86 edited a comment on issue #10577:
[FLINK-15256][hive] HiveModuleFactory should take hive-version as required
supported property
bowenli86 edited a comment on issue #10577: [FLINK-15256][hive] HiveModuleFactory should take hive-version as required supported property
URL: https://github.com/apache/flink/pull/10577#issuecomment-565650334
> The changes look fine, but could you explain why we cannot infer the version when it's missing? We did the familiar thing when loading hiveshims.
good question. I'm thinking we should remove the version inference in HiveCatalog too. We support lots of hive versions now, users may not read the doc carefully and may assume we can just fit into their hive version magically somehow. Say they use the default hive version 2.3.4 but their actual version is 1.2.x, they may run into issues and the errors won't show the root cause.
it's also a bit misleading since the current hive catalog's default version 2.3.4 is not the most widely used one. Most of the time, users always have to change it to 2.2.x, 2.1.x, or 1.2.x.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services